Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bump clion #10430

Closed
wants to merge 2 commits into from
Closed

Feature/bump clion #10430

wants to merge 2 commits into from

Conversation

strahlc
Copy link
Contributor

@strahlc strahlc commented Nov 16, 2018 •
edited

dev-util/clion: version bump to 2018.3
dev-util/clion: remove old version

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-util/clion

dev-util/clion: @strahlc, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Nov 16, 2018
juippis
juippis reviewed Nov 16, 2018
View reviewed changes
dev-util/clion/clion-2018.2.6.ebuild Outdated Show resolved Hide resolved
dev-util/clion/clion-2018.2.6.ebuild Outdated Show resolved Hide resolved
dev-util/clion/clion-2018.2.6.ebuild Outdated Show resolved Hide resolved
@gyakovlev gyakovlev self-assigned this Nov 16, 2018
@strahlc strahlc force-pushed the feature/bump-clion branch 2 times, most recently from 2b8fc16 to ffab681 Compare November 20, 2018 13:23
@strahlc
Copy link
Contributor Author

strahlc commented Nov 23, 2018

@gyakovlev all remarks implemented, please merge

@gyakovlev
Copy link
Member

gyakovlev commented Nov 27, 2018 •
edited

Sorry for delay, long holidays.

looks like it wants <=dev-util/cmake-3.13

image

I have

dev-util/cmake-3.13.0::gentoo was built with the following:
USE="ncurses qt5 system-jsoncpp -doc -emacs -test"

I think it should be fine, and I guess it's just a outdated upstream version constraint.
LMK if it's fine from your point of view and I'll merge, just need to clarify this small detail.
it's it's really unsupported please adjust the dep.

Christian Strahl added 2 commits November 27, 2018 16:28
dev-util/clion: version bump to 2018.3
47f9db2 
Package-Manager: Portage-2.3.51-r1, Repoman-2.3.11
Signed-off-by: Christian Strahl <c.a.strahl@gmail.com>
dev-util/clion: remove old versions
44a994f 
Package-Manager: Portage-2.3.51-r1, Repoman-2.3.11
Signed-off-by: Christian Strahl <c.a.strahl@gmail.com>
@strahlc
Copy link
Contributor Author

strahlc commented Nov 27, 2018

@gyakovlev I've updated the PR to the latest released version of clion. But because even the new version of clion is complaining about cmake 3.13 I've also adapted the ebuild to match the upstream constraints.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-27 15:59 UTC
Newest commit scanned: 44a994f
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/713e5f4/output.html#dev-python/django_polymorphic

@gyakovlev
Copy link
Member

thanks! pushed.
Please don't forget to check cmake requirement next time you bump it, it'd be nice not to have it in the ebuild. hopefully upstream will test and make it work with 3.13
I also closed bug
https://bugs.gentoo.org/672100

@strahlc strahlc deleted the feature/bump-clion branch January 23, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny left review comments

@juippis juippis juippis left review comments

Assignees

@gyakovlev gyakovlev

Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
6 participants
@strahlc @gentoo-bot @gyakovlev @gentoo-repo-qa-bot @mgorny @juippis