Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/humanfriendly: bump to 4.17 #10452

Closed
wants to merge 1 commit into from
Closed

dev-python/humanfriendly: bump to 4.17 #10452

wants to merge 1 commit into from

Conversation

hydrapolic
Copy link
Contributor

Tests pass on ~amd64.

-EAPI=6
+EAPI=7
 
 PYTHON_COMPAT=( python2_7 python3_{4,5,6} )
 PYTHON_REQ_USE="threads(+)"
 
 inherit distutils-r1
 
+MY_PN="python-${PN}"
+MY_P="${MY_PN}-${PV}"
+
 DESCRIPTION="Human friendly output for text interfaces using Python"
 HOMEPAGE="https://pypi.org/project/humanfriendly/ https://humanfriendly.readthedocs.org"
-SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"
+SRC_URI="https://github.com/xolox/${MY_PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
 
 SLOT="0"
 LICENSE="MIT"
@@ -25,9 +28,13 @@
        test? (
                >=dev-python/capturer-2.1[${PYTHON_USEDEP}]
                >=dev-python/coloredlogs-2.0[${PYTHON_USEDEP}]
-               dev-python/pytest[${PYTHON_USEDEP}]
+               >=dev-python/pytest-3.0.7[${PYTHON_USEDEP}]
+               >=dev-python/pytest-2.4.0[${PYTHON_USEDEP}]
        )
        "
+
+S="${WORKDIR}/${MY_P}"
+
 python_test() {
-       esetup.py test
+       pytest -v || die
 }

@hydrapolic
dev-python/humanfriendly: bump to 4.17
7cad09c 
Package-Manager: Portage-2.3.51, Repoman-2.3.12
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/humanfriendly

dev-python/humanfriendly: @gentoo/python

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 20, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-20 07:37 UTC
Newest commit scanned: 7cad09c
Status: ✅ good

No issues found

pull bot pushed a commit to webknjaz/gentoo that referenced this pull request Nov 21, 2018
@hydrapolic @Zlogene
dev-python/humanfriendly: bump to 4.17
271e6c4 
Package-Manager: Portage-2.3.51, Repoman-2.3.12
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Closes: gentoo#10452
Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>
@Zlogene Zlogene closed this Nov 21, 2018
juippis
juippis reviewed Nov 21, 2018
View reviewed changes
dev-python/humanfriendly/humanfriendly-4.17.ebuild
>=dev-python/capturer-2.1[${PYTHON_USEDEP}]
>=dev-python/coloredlogs-2.0[${PYTHON_USEDEP}]
>=dev-python/pytest-3.0.7[${PYTHON_USEDEP}]
>=dev-python/pytest-2.4.0[${PYTHON_USEDEP}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? (pytest required twice)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it should have been pytest-3.0.7 and pytest-cov-2.4.0, i'll correct, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10459

dev-python/humanfriendly/humanfriendly-4.17.ebuild
S="${WORKDIR}/${MY_P}"

python_test() {
pytest -v || die
Copy link
Member

@juippis juippis Nov 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't -vv the correct form? I know this got merged already, but you figure the answer to these questions when bumping the next time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a difference in the output of pytest -v and pytest -vv. Looking at the packages, some packages have only pytest, some pytest -v and some pytest -vv.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://wiki.gentoo.org/wiki/Project:Python/Tests it's a single -v.

@hydrapolic hydrapolic deleted the humanfriendly branch December 17, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@hydrapolic @gentoo-bot @gentoo-repo-qa-bot @juippis @Zlogene