Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail-filter/spamassassin: Add BSD-Resource as a dependency #10460

Closed
wants to merge 1 commit into from

Conversation

Philippe23
Copy link
Contributor

dev-perl/BSD-Resource is needed by the ResourceLimits plugin.
Also add ~ppc64 & ~arm KEYWORDS to dev-perl/BSD-Resource.

Bug: https://bugs.gentoo.org/670988
Signed-off-by: Philippe Chaintreuil gentoo_bugs_peep@parallaxshift.com
Package-Manager: Portage-2.3.51, Repoman-2.3.11

@Philippe23
Copy link
Contributor Author

Philippe23 commented Nov 21, 2018

@nado verified that tests pass on arm on dev-perl/BSD-Resource and @vapier did the same on ppc64 for me.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-perl/BSD-Resource, mail-filter/spamassassin

dev-perl/BSD-Resource: @gentoo/perl
mail-filter/spamassassin: @Philippe23, bug[at]mejor.pl, @orlitzky, @gentoo/proxy-maint

Linked bugs

Bugs linked: 670988


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 21, 2018
@nado
Copy link
Contributor

nado commented Nov 21, 2018

I did not try to reproduce the bug and interactions between dev-perl/BSD-Resource and mail-filter/spamassassin though.

@Philippe23
Copy link
Contributor Author

I did not try to reproduce the bug and interactions between dev-perl/BSD-Resource and mail-filter/spamassassin though.

I highly doubt the ppc team did either. From what I could tell they just made sure that any ebuild tests passed and the build installed without erroring out. Essentially enough for an arch-masked keyword.

@Philippe23 Philippe23 force-pushed the bug-670988 branch 3 times, most recently from 0405081 to 2753a41 Compare February 7, 2019 23:51
@Philippe23
Copy link
Contributor Author

Updated the copyright notices since this has spilled into a new year.

@Philippe23
Copy link
Contributor Author

Changes to BSD-Resource (adding arch keywords) have been made by the arch team in https://bugs.gentoo.org/677512 so I removed that file from this PR.

The PR is now just a single line adding BSD-Resource to OPTDEPEND to get https://bugs.gentoo.org/670988 fixed.

@orlitzky can you merge this in or kick it back to me with improvement requests? Thanks.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-02-17 03:21 UTC
Newest commit scanned: d609be5
Status: ✅ good

No issues found

@orlitzky
Copy link
Contributor

Yeah I'll take care of it. Two tiny things:

  • "dependency" is typo'd in the commit message
  • You can use the Closes: tag (instead of "Bug:") in the commit message to automatically close the associated bug.
  • In fact, you can add Closes: https://github.com/gentoo/gentoo/pull/10460 to the commit message too, to automatically close this PR.

dev-perl/BSD-Resource is needed by the ResourceLimits plugin.

Closes: https://bugs.gentoo.org/670988
Closes: gentoo#10460
Signed-off-by: Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
Package-Manager: Portage-2.3.51, Repoman-2.3.11
@Philippe23
Copy link
Contributor Author

Philippe23 commented Feb 17, 2019

Thanks for the pointers/tips. Good things to know.

Commit message + tags updated. (Also enabled spell checking in vim, since I always screw up "dependency".)

@Philippe23 Philippe23 changed the title mail-filter/spamassassin: Add BSD-Resource as a dependancy mail-filter/spamassassin: Add BSD-Resource as a dependency Feb 17, 2019
@orlitzky
Copy link
Contributor

Thanks, my own personal achilles heel is "maintenance," which I tend to spell in three or four ways, none of them correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants