Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtual/python-funcsigs: require correct USE flags of python/funcsigs #10603

Closed
wants to merge 1 commit into from
Closed

virtual/python-funcsigs: require correct USE flags of python/funcsigs #10603

wants to merge 1 commit into from

Conversation

DarthGandalf
Copy link
Contributor

Disclaimer: I don't know whether it's the right fix.

Here's what happened: I tried to get rid of python 2, but eventually gave up, and tried to bring python 2 back. I have FEATURES=test, and various builds were failing with python2_7 because they couldn't open module funcsigs in the test phase.
It turns out they depend on virtual/python-funcsigs[python2_7], but virtual/python-funcsigs depends on python/funcsigs without requiring any specific python. emerge -DNu @world does attempt to update it:
[ebuild R ] dev-python/funcsigs-1.0.2-r1::gentoo USE="test" PYTHON_TARGETS="python2_7* python3_6 (-pypy) -pypy3 -python3_4 -python3_5 (-python3_7)" 0 KiB, but does that after trying to build other packages which depend on it.
Adding [${PYTHON_USEDEP}] fixes it for me.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 10, 2018
@DarthGandalf DarthGandalf changed the title virtual/python-funcsigs: require correct USE flags of python/funcsigs [please reassign] virtual/python-funcsigs: require correct USE flags of python/funcsigs Dec 29, 2018
@gentoo-bot gentoo-bot changed the title [please reassign] virtual/python-funcsigs: require correct USE flags of python/funcsigs virtual/python-funcsigs: require correct USE flags of python/funcsigs Dec 29, 2018
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @DarthGandalf
Areas affected: ebuilds
Packages affected: virtual/python-funcsigs

virtual/python-funcsigs: @gentoo/python

Linked bugs

Bugs linked: 672890

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Dec 29, 2018
floppym
floppym suggested changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@floppym floppym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this version 2 instead of rev-bumping version 1.

virtual/python-funcsigs/python-funcsigs-1-r1.ebuild Outdated

RDEPEND="
${PYTHON_DEPS}
$(python_gen_cond_dep '>=dev-python/funcsigs-1[${PYTHON_USEDEP}]' python2_7 python3_{3,4,5,6,7} pypy{,3} )"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add python3_6 and 3_7 on this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Can you explain why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality provided by dev-python/funcsigs is included in the standard library shipped with python 3.6 and 3.7.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-12-29 21:57 UTC
Newest commit scanned: 4259d88
Status: ✅ good

No issues found

anaveragehuman pushed a commit to anaveragehuman/gentoo that referenced this pull request Jan 4, 2019
@DarthGandalf @anaveragehuman
virtual/python-funcsigs: require correct USE flags of python/funcsigs
2af90ba 
Closes: https://bugs.gentoo.org/672890
Closes: gentoo#10603
Signed-off-by: Alexey Sokolov <sokolov@google.com>
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@DarthGandalf DarthGandalf deleted the funcsigs branch January 6, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floppym floppym floppym requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@DarthGandalf @gentoo-bot @gentoo-repo-qa-bot @floppym