Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lisp/roswell: Add roswell ebuild #10684

Closed
wants to merge 1 commit into from

Conversation

sheepduke
Copy link
Contributor

@sheepduke sheepduke commented Dec 23, 2018

Roswell is a Lisp implementation installer/manager, launcher, and much more!

Roswell started out as a command-line tool with the aim to make installing and
managing Common Lisp implementations really simple and easy.

Roswell has now evolved into a full-stack environment for Common Lisp
development, and has many features that makes it easy to test, share, and
distribute your Lisp applications. With Roswell, we aim to push the Common Lisp
community to a whole new level of productivity.

Roswell is still in beta. Despite this, the basic interfaces are stable and not
likely to change. Roswell currently works well on Unix-like platforms such as
Linux, Mac OS X and FreeBSD. Roswell also works on other operating systems, but
currently some parts or features might be missing or unstable.

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). no signoff One or more commits do not indicate GCO sign-off. labels Dec 23, 2018
@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild [please reassign] dev-lisp/roswell: Add roswell ebuild Dec 23, 2018
@gentoo-bot gentoo-bot changed the title [please reassign] dev-lisp/roswell: Add roswell ebuild dev-lisp/roswell: Add roswell ebuild Dec 23, 2018
@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. and removed assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Dec 23, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-12-23 08:36 UTC
Newest commit scanned: b80a427
Status: ❌ broken

There are too many broken packages to determine whether the breakages were added by the pull request. If in doubt, please rebase.

Issues:https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#app-text/ronn
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-db/qdbm
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-libs/xapian-bindings
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/abstract
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/allison
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/asciidoctor
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/asciimath
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/atomic
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/bacon
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/bcat
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/blankslate
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/bluecloth
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/builder
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/bundler
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/childprocess
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/coderay
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/coffee-script
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/coffee-script-source
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/daemons
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/did_you_mean
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/diff-lcs
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/erubis
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/execjs
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/fakefs
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/fast_xs
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/fcgi
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/ffi
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/gherkin
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/haml
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/hoe
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/hoe-seattlerb
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/hpricot
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/instantiator
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/introspection
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/json
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/kpeg
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/listen
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/locale
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/log4r
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/maruku
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/metaclass
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/mime-types
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/minitest
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/mocha
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/multi_json
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/multi_test
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/mustache
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/nanotest
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/net-telnet
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/nokogiri
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/nokogiri-diff
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/pkg-config
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/power_assert
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/racc
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rack
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rake
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rake-compiler
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rb-inotify
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rdiscount
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rdoc
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/redcarpet
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/redcloth
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rexical
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rr
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rrdtool-bindings
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rspec
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rspec-core
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rspec-expectations
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rspec-mocks
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rspec-support
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/ruby-beautify
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/ruby-gettext
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/ruby2ruby
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/ruby_parser
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rubygems
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/rubyzip
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/sass
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/session
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/sexp_processor
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/slim
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/spork
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/syntax
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/tdiff
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/temple
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/term-ansicolor
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/test-unit
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/test-unit-rr
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/text
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/thread_order
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/thread_safe
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/tidy-ext
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/tilt
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/tins
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/unindent
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/xmlrpc
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/yajl-ruby
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/yard
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-ruby/zentest
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-util/aruba
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-util/cucumber
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-util/cucumber-core
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#dev-util/cucumber-wire
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#virtual/ruby-ffi
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#virtual/ruby-ssl
https://qa-reports.gentoo.org/output/gentoo-ci/93ccdec/output.html#virtual/rubygems

@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild dev-lisp/roswell: Add roswell ebuild [please re-assign] Dec 23, 2018
@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild [please re-assign] dev-lisp/roswell: Add roswell ebuild [please reassign] Dec 23, 2018
@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild [please reassign] [please reassign] dev-lisp/roswell: Add roswell ebuild Dec 23, 2018
@gentoo-bot gentoo-bot changed the title [please reassign] dev-lisp/roswell: Add roswell ebuild dev-lisp/roswell: Add roswell ebuild Dec 23, 2018
@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Dec 23, 2018
@gentoo-bot gentoo-bot added the no signoff One or more commits do not indicate GCO sign-off. label Mar 14, 2019
@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild [please reassign] dev-lisp/roswell: Add roswell ebuild Mar 14, 2019
@gentoo-bot gentoo-bot changed the title [please reassign] dev-lisp/roswell: Add roswell ebuild dev-lisp/roswell: Add roswell ebuild Mar 14, 2019
@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Mar 14, 2019
@sheepduke
Copy link
Contributor Author

@juippis Done.

Could you please check it?

KEYWORDS="~amd64 ~x86"

src_configure() {
eautoreconf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs to src_prepare.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Will be changed.

@juippis
Copy link
Member

juippis commented Mar 14, 2019

Getting these QA warnings:

 * 	make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.

I am not 100 % sure about this, but I think you need to add phases and force with emake -j1.


src_prepare() {
    default
    eautoreconf
}

src_configure() {
    econf
}

src_compile() {
    emake -j1
}

src_test() {
    emake -j1 check
}

src_install() {
    emake DESTDIR="${D}" -j1 install
}

worked for me, but you might be able to just use a single line of sed to force MAKEOPTS="-j1" in Makefile or something. It'd be nice if you could investigate a possibility to do such.

EDIT: From this example, the src_configure part can be removed.

@sheepduke
Copy link
Contributor Author

sheepduke commented Mar 15, 2019

Getting these QA warnings:

 * 	make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
 * 	make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.

I am not 100 % sure about this, but I think you need to add phases and force with emake -j1.


src_prepare() {
    default
    eautoreconf
}

src_configure() {
    econf
}

src_compile() {
    emake -j1
}

src_test() {
    emake -j1 check
}

src_install() {
    emake DESTDIR="${D}" -j1 install
}

worked for me, but you might be able to just use a single line of sed to force MAKEOPTS="-j1" in Makefile or something. It'd be nice if you could investigate a possibility to do such.

EDIT: From this example, the src_configure part can be removed.

@juippis
I did not really find a good way to solve it gracefully.

So I changed the ebuild file according to your previous solution and tested.

Please check it again.

Signed-off-by: YUE Daian <sheepduke@gmail.com>
@sheepduke sheepduke changed the title dev-lisp/roswell: Add roswell ebuild [please reassign] dev-lisp/roswell: Add roswell ebuild Mar 15, 2019
@gentoo-bot gentoo-bot changed the title [please reassign] dev-lisp/roswell: Add roswell ebuild dev-lisp/roswell: Add roswell ebuild Mar 15, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @sheepduke
Areas affected: ebuilds
Packages affected: dev-lisp/roswell

dev-lisp/roswell: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Mar 15, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-15 15:18 UTC
Newest commit scanned: a79c5f4
Status: ✅ good

No issues found

@juippis
Copy link
Member

juippis commented Aug 1, 2019

Sorry it took this long. Welcome aboard!

  upstream.workaround           2
   dev-lisp/roswell/roswell-19.3.10.97.ebuild: Upstream parallel compilation bug (ebuild calls emake -j1 on line: 23)
   dev-lisp/roswell/roswell-19.3.10.97.ebuild: Upstream parallel compilation bug (ebuild calls emake -j1 on line: 31)

Try to get this resolved by upstream before the next release.

@gentoo-bot gentoo-bot closed this in 6b2e4df Aug 1, 2019
@sheepduke
Copy link
Contributor Author

The problem has been fixed. Now everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants