Bitcoin 0.17.1 #10710

luke-jr · 2018-12-30T00:12:20Z

net-p2p/bitcoin{-qt,d} now ~~default to~~ can use the bundled LevelDB, which is modified to use more mmaps for a performance improvement; a system-leveldb USE flag has been added to continue to use the system library instead (and is enabled by default).
dev-libs/leveldb-1.20 appears to be compatible with Bitcoin (I reviewed the relevant diffs), so I am adding it to virtual/bitcoin-leveldb.
dev-libs/libsecp256k1 has been bumped to 0.1_pre20170928 which corresponds (more or less) to the version bundled with 0.17.1.
~ppc64 keywords have been added (this is my development platform).
Knots has dropped the optional-libevent patch, so libevent is now required.
We moved debian/rpm packaging stuff to another repo (it tends to get updated post-release), but apparently the .desktop and .protocol files went with it, so I have added these to net-p2p/bitcoin-qt/files for now.

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

gentoo-bot · 2018-12-30T00:16:12Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @luke-jr
Areas affected: ebuilds
Packages affected: dev-libs/libsecp256k1, dev-libs/univalue, dev-util/bitcoin-tx, net-libs/libbitcoinconsensus, net-p2p/bitcoin-cli...

dev-libs/libsecp256k1: @luke-jr, @gentoo/proxy-maint
dev-libs/univalue: @luke-jr, @gentoo/proxy-maint
dev-util/bitcoin-tx: @luke-jr, @gentoo/proxy-maint
net-libs/libbitcoinconsensus: @luke-jr, @gentoo/proxy-maint
net-p2p/bitcoin-cli: @luke-jr, @gentoo/proxy-maint
net-p2p/bitcoin-qt: @luke-jr, @gentoo/proxy-maint
net-p2p/bitcoind: @luke-jr, @gentoo/proxy-maint
virtual/bitcoin-leveldb: @luke-jr, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

candrews · 2019-01-09T14:19:07Z

* net-p2p/bitcoin{-qt,d} now default to use the bundled LevelDB, which is modified to use more mmaps for a performance improvement; a system-leveldb USE flag has been added to continue to use the system library instead.

I don't like this. Bundled libraries are against Gentoo policy: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies If there must be such a use flag, please set it to use the system library by default.

candrews · 2019-01-09T14:19:51Z

dev-libs/libsecp256k1/libsecp256k1-0.1_pre20170928.ebuild

+# Copyright 1999-2018 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please bump to EAPI=7

candrews · 2019-01-09T14:21:54Z

dev-libs/libsecp256k1/libsecp256k1-0.1_pre20170928.ebuild

+src_install() {
+	dodoc README.md
+	emake DESTDIR="${D}" install
+	prune_libtool_files


Banned in EAPI=7, use something like find "${D}" -name '*.la' -delete || die instead. See https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html

candrews · 2019-01-09T14:22:37Z

dev-util/bitcoin-tx/bitcoin-tx-0.17.1.ebuild

+# Copyright 1999-2018 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please use EAPI=7

candrews · 2019-01-09T14:23:48Z

dev-util/bitcoin-tx/bitcoin-tx-0.17.1.ebuild

+	echo "#define BUILD_SUFFIX gentoo${PVR#${PV}}" >src/obj/build.h || die
+
+	eautoreconf
+	rm -r src/leveldb src/secp256k1 || die


Should this line be before eautoreconf?

IIRC, they need to exist for eautoreconf to work, but can be deleted safely afterward.

candrews · 2019-01-09T14:24:07Z

net-libs/libbitcoinconsensus/libbitcoinconsensus-0.17.1.ebuild

+# Copyright 1999-2018 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please use EAPI=7

candrews · 2019-01-09T14:24:41Z

net-p2p/bitcoin-cli/bitcoin-cli-0.17.1.ebuild

+# Copyright 1999-2018 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please use EAPI=7

luke-jr · 2019-01-10T10:41:43Z

I don't like this. Bundled libraries are against Gentoo policy: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies If there must be such a use flag, please set it to use the system library by default.

Even though there is likely an annoying performance hit? I hate bundled dependencies too, but I would think the end user experience is more important, no?

candrews · 2019-01-10T14:27:15Z

I don't like this. Bundled libraries are against Gentoo policy: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies If there must be such a use flag, please set it to use the system library by default.

Even though there is likely an annoying performance hit? I hate bundled dependencies too, but I would think the end user experience is more important, no?

Correct. It's Gentoo's position that bundled dependencies are only used as a last resort if the system dependency doesn't work at all. This isn't such a case.

luke-jr · 2019-01-10T15:00:27Z

So just to be clear, do you want me to revert it back to system libs only, or simply change the USE default?

candrews · 2019-01-10T15:03:36Z

Just changing the USE flag default would be sufficient :)

- Update upstream URIs - Add ppc64 keyword Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

…ends) Closes: https://bugs.gentoo.org/672070 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

Closes: https://bugs.gentoo.org/668520 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

Closes: https://bugs.gentoo.org/672064 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

luke-jr · 2019-01-10T18:08:13Z

Okay, all the changes requested have been made, with exception to the rm/autoreconf ordering (which I confirmed must be done in that order).

gentoo-repo-qa-bot · 2019-01-10T18:37:20Z

Pull request CI report

Report generated at: 2019-01-10 18:37 UTC
Newest commit scanned: 109b1bf
Status: ✅ good

No issues found

candrews · 2019-01-11T21:39:10Z

merged! Thank you :)

dev-libs/univalue: keyworded 1.0.4 for ppc64

06cf774

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Dec 30, 2018

luke-jr force-pushed the bitcoin-0.17.1 branch from 256f80e to 414a7a1 Compare December 30, 2018 00:17

candrews reviewed Jan 9, 2019

View reviewed changes

luke-jr added 7 commits January 10, 2019 18:07

dev-libs/libsecp256k1: Bump to 0.1_pre20170928

ef88f2d

- Update upstream URIs - Add ppc64 keyword Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

virtual/bitcoin-leveldb: Add =dev-libs/leveldb-1.20 (only changed dep…

ff2fdcd

…ends) Closes: https://bugs.gentoo.org/672070 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

net-p2p/bitcoin-qt: Bump to 0.17.1

99f852a

Closes: https://bugs.gentoo.org/668520 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

net-p2p/bitcoind: Bump to 0.17.1

fc06965

Closes: https://bugs.gentoo.org/672064 Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

net-p2p/bitcoin-cli: Bump to 0.17.1

674fb18

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

net-libs/libbitcoinconsensus: Bump to 0.17.1

6895cdf

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

dev-util/bitcoin-tx: Bump to 0.17.1

109b1bf

Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>

luke-jr force-pushed the bitcoin-0.17.1 branch from 414a7a1 to 109b1bf Compare January 10, 2019 18:07

luke-jr closed this Jan 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bitcoin 0.17.1 #10710

Bitcoin 0.17.1 #10710

luke-jr commented Dec 30, 2018 •

edited

gentoo-bot commented Dec 30, 2018

candrews commented Jan 9, 2019

candrews Jan 9, 2019

candrews Jan 9, 2019

candrews Jan 9, 2019

candrews Jan 9, 2019

luke-jr Jan 10, 2019

candrews Jan 9, 2019

candrews Jan 9, 2019

luke-jr commented Jan 10, 2019

candrews commented Jan 10, 2019

luke-jr commented Jan 10, 2019

candrews commented Jan 10, 2019

luke-jr commented Jan 10, 2019

gentoo-repo-qa-bot commented Jan 10, 2019

candrews commented Jan 11, 2019

Bitcoin 0.17.1 #10710

Bitcoin 0.17.1 #10710

Conversation

luke-jr commented Dec 30, 2018 • edited

gentoo-bot commented Dec 30, 2018

Copyright policy change

Pull Request assignment

Linked bugs

candrews commented Jan 9, 2019

candrews Jan 9, 2019

Choose a reason for hiding this comment

candrews Jan 9, 2019

Choose a reason for hiding this comment

candrews Jan 9, 2019

Choose a reason for hiding this comment

candrews Jan 9, 2019

Choose a reason for hiding this comment

luke-jr Jan 10, 2019

Choose a reason for hiding this comment

candrews Jan 9, 2019

Choose a reason for hiding this comment

candrews Jan 9, 2019

Choose a reason for hiding this comment

luke-jr commented Jan 10, 2019

candrews commented Jan 10, 2019

luke-jr commented Jan 10, 2019

candrews commented Jan 10, 2019

luke-jr commented Jan 10, 2019

gentoo-repo-qa-bot commented Jan 10, 2019

Pull request CI report

candrews commented Jan 11, 2019

luke-jr commented Dec 30, 2018 •

edited