Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/libzip: version bump 1.5.1 #10846

Closed
wants to merge 1 commit into from
Closed

Conversation

hungte
Copy link

@hungte hungte commented Jan 16, 2019

Upgrade libzip from 1.3.0 to 1.5.1.

@hungte
Copy link
Author

hungte commented Jan 16, 2019

@vapier this is the PR.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @hungte
Areas affected: ebuilds
Packages affected: dev-libs/libzip

dev-libs/libzip: @creffett, @gentoo/kde

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jan 16, 2019
@hungte
Copy link
Author

hungte commented Jan 17, 2019

e3f230e includes signing

dev-libs/libzip/libzip-1.5.1.ebuild Outdated Show resolved Hide resolved
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some unhandled dependencies here, as seen in CMakeLists.txt:

OPTION(ENABLE_GNUTLS "Enable use of GnuTLS" ON)
OPTION(ENABLE_OPENSSL "Enable use of OpenSSL" ON)
OPTION(ENABLE_COMMONCRYPTO "Enable use of CommonCrypto" ON)

@hungte
Copy link
Author

hungte commented Jan 30, 2019

There seem to be some unhandled dependencies here, as seen in CMakeLists.txt:
OPTION(ENABLE_GNUTLS "Enable use of GnuTLS" ON)
OPTION(ENABLE_OPENSSL "Enable use of OpenSSL" ON)

Added to dependency.

OPTION(ENABLE_COMMONCRYPTO "Enable use of CommonCrypto" ON)

Common crypto is currently not available in portage, but the system will still use it if found.
i.e., the ON here actually means "auto-detect" so there won't be dependency issue on portage.

Signed-off-by: Hung-Te Lin <hungte@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-01-31 09:56 UTC
Newest commit scanned: 7cb54ee
Status: ✅ good

All QA issues have been fixed!

@a17r a17r added the do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. label Feb 4, 2019
@a17r
Copy link
Member

a17r commented Feb 4, 2019

Thanks for your work, unfortunately the port to cmake requires bigger changes not feasible to deal with in a PR. I've got it mostly ready and will push it to tree after some testing.

@gentoo-bot gentoo-bot closed this in 34e6aee Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
6 participants