Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/hyperscan: Version bump 5.1.0 #10864

Closed
wants to merge 1 commit into from
Closed

dev-libs/hyperscan: Version bump 5.1.0 #10864

wants to merge 1 commit into from

Conversation

okias
Copy link
Contributor

@okias okias commented Jan 18, 2019

Closes: #9863
Closes: https://bugs.gentoo.org/674220

Original author: Christian Rößner
Signed-off-by: David Heidelberg david@ixit.cz

@okias okias mentioned this pull request Jan 18, 2019
Closed
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @okias
Areas affected: ebuilds
Packages affected: dev-libs/hyperscan

dev-libs/hyperscan: c[at]roessner.co, @gentoo/proxy-maint

Linked bugs

Bugs linked: 674220

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 18, 2019
@okias
Copy link
Contributor Author

okias commented Feb 21, 2019

Month passed away, any progress on this?

@a17r
Copy link
Member

a17r commented Feb 21, 2019

@croessner are you still there?

a17r
a17r suggested changes Feb 21, 2019
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • (v2) makes no sense in the commit message.
  • How about bumping to 5.1.0 instead?

dev-libs/hyperscan/hyperscan-5.0.0.ebuild Outdated Show resolved Hide resolved
dev-libs/hyperscan/hyperscan-5.0.0.ebuild Outdated Show resolved Hide resolved
@okias
dev-libs/hyperscan: Version bump 5.1.0
1b99a2b 
Closes: #9863
Closes: https://bugs.gentoo.org/674220

Original author: Christian Rößner
Signed-off-by: David Heidelberg <david@ixit.cz>
@okias
Copy link
Contributor Author

okias commented Feb 21, 2019

done :)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-02-21 17:59 UTC
Newest commit scanned: 1b99a2b
Status: ✅ good

No issues found

@croessner
Copy link
Contributor

@a17r I am alive 😊

@a17r
Copy link
Member

a17r commented Feb 21, 2019

@croessner and do you approve of this PR?

@croessner
Copy link
Contributor

Yes perfect 👍

@okias okias changed the title dev-libs/hyperscan: Version bump 5.0.0 (v2) dev-libs/hyperscan: Version bump 5.1.0 Feb 22, 2019
@okias
Copy link
Contributor Author

okias commented Feb 22, 2019

@a17r I cannot get rid of "Changes requested" can you merge it anyway?

@okias okias deleted the hyperscan branch February 23, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydrapolic hydrapolic hydrapolic left review comments

@a17r a17r a17r approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
6 participants
@okias @gentoo-bot @a17r @gentoo-repo-qa-bot @croessner @hydrapolic