net-analyzer/authforce: take maintainership, EAPI7, fix manpage installation #10935
Conversation
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @mm1ke net-analyzer/authforce: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2019-01-29 21:00 UTC No issues found |
| KEYWORDS="~amd64 ~ppc ~x86" | ||
| IUSE="curl nls" | ||
|
|
||
| DEPEND=" |
There was a problem hiding this comment.
Seems like maybe two of those should be in an RDEPEND?
There was a problem hiding this comment.
I've put readline and curl into RDEPEND. I've also added gettext to BDEPEND. Since DEPEND is empty now i've added DEPEND=${RDEPEND}, however i'm not sure if that is correct?
There was a problem hiding this comment.
since presumably both dependencies will be needed at configure/build time that would be correct, yes.
mm1ke
force-pushed
the
authforce-Ld6lzcXg
branch
from
0840495
to
4bf9d53
Compare
| KEYWORDS="~amd64 ~ppc ~x86" | ||
| IUSE="curl nls" | ||
|
|
||
| DEPEND=${RDEPEND} |
There was a problem hiding this comment.
either DEPEND comes first and defines all the deps, which RDEPEND then inherits, or DEPEND inherits properly after RDEPEND was defined. ;)
There was a problem hiding this comment.
Thanks for the clarification :) I've updated the ebuild accordingly.
| IUSE="curl nls" | ||
|
|
||
| DEPEND=${RDEPEND} | ||
| RDEPEND="sys-libs/readline |
There was a problem hiding this comment.
Check readline package, you'll want to use a slot operator for sure here. :0= to be precise.
There was a problem hiding this comment.
Updated, thx for the hint.
mm1ke
force-pushed
the
authforce-Ld6lzcXg
branch
from
4bf9d53
to
8a0c512
Compare
|
|
||
| RDEPEND="sys-libs/readline:0= | ||
| curl? ( net-misc/curl )" | ||
| DEPEND=${RDEPEND} |
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
mm1ke
force-pushed
the
authforce-Ld6lzcXg
branch
from
8a0c512
to
303b45c
Compare
Hi,
I would like to take over net-analyzer/authforce.
For the start i've updated the ebuild for EAPI7 and fixed the manpage installation (and also decompressed the precompressed manpage file). For some reason the Makefile want's to install the manpage under
/usr/share/man/mangwhich doesn't make sense at all and wouldn't be accessible for the user.Please review.