media-sound/qtractor: Bump to 0.9.4 #11011
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @simonvanderveldt media-sound/qtractor: At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
There was a problem hiding this comment.
P.S. This is a bump and drop in 1 commit, I'm not sure if that's OK or not. If not just let me know I'll split it into 2 commits.
Indeed, please keep them separate commits. Also, only drop it if you are absolutely sure there is no regression over 0.9.2 that may be worth keeping the old version for some time. ;)
Also, for EAPI-7 you should move all content of DEPEND (except RDEPEND inheritance) into BDEPEND instead.
|
Also, please add your signoff so we can merge your PR. |
Signed-off-by: Simon van der Veldt <simon.vanderveldt@gmail.com>
Signed-off-by: Simon van der Veldt <simon.vanderveldt@gmail.com>
simonvanderveldt
force-pushed
the
qtractor-bump-0.9.4
branch
from
76761f7
to
3229491
Compare
Done. There are no real significant changes between 0.9.2 and 0.9.4 and it's all working fine so I think this is fine. Rui only does small changes nowadays so breakage seldom happens :)
I've incorporated this change, also moved Added my signoff to the commits as well. |
There was a problem hiding this comment.
* One or more compressed files were found in docompress-ed directories.
* Please fix the ebuild not to install compressed files (manpages,
* documentation) when automatic compression is used:
*
* /usr/share/man/man1/qtractor.fr.1.gz
* /usr/share/man/man1/qtractor.1.gz
Please look into fixing those (likely needs buildsys patching).
|
Yeah, I noticed those. That was already the case for the old(er) version(s) as well though, didn't want to add changes unrelated to the bump. What would be the suggested way to fix this? |
|
Removing line 349 should be enough, you can add the fix in a separate commit ofc. |
|
@a17r I've added a patch that should address the QA issue. |
Signed-off-by: Simon van der Veldt <simon.vanderveldt@gmail.com>
simonvanderveldt
force-pushed
the
qtractor-bump-0.9.4
branch
from
95575af
to
2ffcb5a
Compare
Pull request CI reportReport generated at: 2019-02-10 23:41 UTC No issues found |
Qt4 support was dropped in it's entirety so I've removed the econf flag for it.
With the removal of Qt4 support the
--with-qt5flag was also dropped, so removed that as well. Emering/compilation still works fine.Also validated that running and opening/using projects works correctly.
P.S. This is a bump and drop in 1 commit, I'm not sure if that's OK or not. If not just let me know I'll split it into 2 commits.