Various fixes for dev-libs/{sway{idle,lock,},wlroots} & version bump to sway-1.0_rc2

[SpeedJack]

@prometheanfire @flappyports
This merges the changes introduced by Matthew and those made in the old PR #10932 .
Changes are described in commit messages. Apparently, these are a lot. But these are mainly minor edits to make all ebuilds in the same format (reorder of (R)DEPEND/HOMEPAGE/DESCRIPTION; alphabetical order for use flags; etc.); Other are fixes to minor bugs (wayland-protocols and scdoc in BDEPEND; add missing xkeyboard-config dep; etc.); Some are choices, that may be argueable (wl-clipboard removed from dependency list; swaybar & swaybg use flags against only one flag gdk-pixbuf; doc -> man renaming; etc.).

Regarding bug #677522, I tried building every version (except the live version) of Sway without git and it works for me.

Matthew said that he opened a thread on gentoo-dev to ask for a new category wayland-misc or something like. I hope it will be approved - but if not, I would consider moving dev-libs/{sway{lock,idle},wl-clipboard} to app-misc, which is a better category.

[prometheanfire]

• we should probably just remove the betas (and earlier) given their stability.
  • perhaps for wlroots too
• Since on disk stuff is being edited sway-1.0_rc1 should be renamed to sway-1.0_rc1-r1
• MESON_AUTO_DEPEND=no should be specified if we are specifying which meson ourselves
• we should use meson_use when we can (my opinion)
• ~dev-libs/wlroots-0.3[elogind=,systemd=,X=] is problematic unless upstream states they ONLY support that version it should be >=. static deps make maintenance a pain.
• (minor) tray should be auto-enabled?
• {R,B,}DEPEND and first lines being newlines, that's done to aid readability.

Hard to tell via the diff, but latest version and 9999 should be the same (unless 9999 had changes not in latest version), this lets us copy 9999 to the new release when it comes for easy bumps.

[prometheanfire]

I think swayidle needs systemd[policykit] to actually be allowed to send the lock

swayidle -w before-sleep 'swaylock'
Failed to send Inhibit signal: Permission denied

[prometheanfire]

yep, remerged systemd and reloaded systemd-logind and now it works. elogind probably needs the same.

[SpeedJack]

* Since on disk stuff is being edited sway-1.0_rc1 should be renamed to sway-1.0_rc1-r1

* we should use meson_use when we can (my opinion)

* `~dev-libs/wlroots-0.3[elogind=,systemd=,X=]` is problematic unless upstream states they ONLY support that version it should be `>=`.  static deps make maintenance a pain.

I think swayidle needs systemd[policykit] to actually be allowed to send the lock

Done.

* {R,B,}DEPEND and first lines being newlines, that's done to aid readability.

With {R,B,}DEPEND you mean also to change the order of these vars? In skel.ebuild DEPEND comes before RDEPEND.

* MESON_AUTO_DEPEND=no should be specified if we are specifying which meson ourselves

MESON_AUTO_DEPEND has been removed. But anyway meson.eclass has been updated 4 days ago to auto-depend on >=meson-0.48.2 - so I've removed the explicit dependency.

* we should probably just remove the betas (and earlier) given their stability.
  
  * perhaps for wlroots too

I've removed older versions of sway and wlroots except the last 2 versions of each: this would allow a user to fallback to the older version if something breaks in the latest.

* (minor) tray should be auto-enabled?

Sway's tray feature now depends on systemd/elogind (see REQUIRED_USE). Default enabling it would force the user to either enable systemd/elogind or to explicity disable tray.

Hard to tell via the diff, but latest version and 9999 should be the same (unless 9999 had changes not in latest version), this lets us copy 9999 to the new release when it comes for easy bumps.

The only difference between sway-1.0_rc1-r1 and sway-9999 is:

28c28
<       >=dev-libs/wlroots-0.3[elogind=,systemd=,X=]
---
>       ~dev-libs/wlroots-9999[elogind=,systemd=,X=]

While sway-9999 actually works with wlroots-0.3, I think it's better to leave the dep on wlroots-9999 - or we risk having to edit the ebuild each time the upstream devs add something new to wlroots and sway.

[prometheanfire]

If we want to have wlroots-9999 for sway-9999 then we should probably lock it behind a if VER string like is done in other places. the other changes sound good and I'll review it fully some time today.

[SpeedJack]

I'll also add sway 1.0-rc2 (released 4h ago) to this PR later today.

[prometheanfire]

ok, I've updated to that locally already (using the rc1 ebuild, deps didn't change it looks like).

[prometheanfire]

I think all of this looks ok (I have not verified 9999 and latest version are the same, but I think they are and it'll be verified before push). The main question I have is if you've verified the depend/rdepend changes. I have a feeling removing stuff from rdepend could break stuff (once the depends are removed from the system on depclean). use lddtree and the like to check linking (and runtime deps).

[SpeedJack]

use lddtree and the like to check linking (and runtime deps).

I've checked. deps seems fine. I see nothing that can break.

[SpeedJack]

I'm still interested in hearing how upstream intends this to be used.

Sway's wiki
I've also added the wlroots[filecaps=] constraint to Sway: as per wiki, to use Sway with cap_sys_admin, wlroots must be compiled with libcap enabled.

The PR should be ok now.

[prometheanfire]

it looks like they want to switch to setuid

10:29 <           emersion > ddevault, do you remmember why we don't drop caps anymore?
10:35 <           ddevault > emersion: no
10:35 <           ddevault > emersion: I just want to use setuid going forward
10:35 <           emersion > yeah, i don't think caps add any value

[SpeedJack]

it looks like they want to switch to setuid

well, we have 3 choices:

1. force the use of setuid and totally drop caps;
2. let the user decide whether to use setuid or caps, and by default use caps;
3. let the user decide whether to use setuid or caps, and by default use setuid;

Currently we are on (2), since filecaps is default enabled by fcaps.eclass.
I think we can obtain (3) by setting -filecaps in IUSE, forcing the flag to be default disabled.
Imho it's fine to leave it as is (choice 2), since it let the user to choose between caps/setuid (and I usually feel better when I can choose) and does not add a redundant flag (-filecaps) to the IUSE var.

[prometheanfire]

option 4, force setuid when !systemd and !elogind

this is a security issue

[prometheanfire]

but for now leave it as it until upstream decides what to do

[SpeedJack]

Upstream suggests to use only setuid: swaywm/sway#3668
So I've removed caps in favor of setuid.
Note: done in pkg_preinst since fperms can not be used in pkg_postinst.

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @SpeedJack
Areas affected: ebuilds
Packages affected: dev-libs/sway, dev-libs/swayidle, dev-libs/swaylock, dev-libs/wlroots

dev-libs/sway: @flappyports, @prometheanfire, @Hummer12007, @SpeedJack
dev-libs/swayidle: @prometheanfire
dev-libs/swaylock: @prometheanfire
dev-libs/wlroots: @flappyports, @SpeedJack

Linked bugs

Bugs linked: 675978, 672590, 677774, 674640, 677748, 677654
Cross-linking bugs disabled due to large number of bugs linked.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[FuzzyGophers]

This has been merged. We can continue to address the setuid and fcaps in future updates.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2019-02-13 00:23 UTC
Newest commit scanned: 6bcc71c
Status: ✅ good

No issues found