Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/cryptography-2.5 version bump #11077

Closed
wants to merge 2 commits into from

Conversation

candrews
Copy link
Member

dev-python/cryptography-vectors-2.5 version bump https://bugs.gentoo.org/678180
dev-python/cryptography-2.5 version bump https://bugs.gentoo.org/678176

Closes: https://bugs.gentoo.org/678180
Package-Manager: Portage-2.3.60, Repoman-2.3.12
Signed-off-by: Craig Andrews <candrews@gentoo.org>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @candrews
Areas affected: ebuilds
Packages affected: dev-python/cryptography, dev-python/cryptography-vectors

dev-python/cryptography: @gentoo/python
dev-python/cryptography-vectors: @gentoo/python

Linked bugs

Bugs linked: 678176, 678180


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 16, 2019
Copy link
Member

@prometheanfire prometheanfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@candrews
Copy link
Member Author

@prometheanfire thanks for pointing that out

I assume we want to keep the dependency on dev-python/idna - or do you want to add an idna use flag?

The only other relevant change seems to be with cffi, so I've force pushed an update to fix that.

How's it look now?

@prometheanfire
Copy link
Member

Ya, that link didn't work so well...
It does not look we do docs builds so the twine change isn't needed.
idna may be useful, but I'd call the use flag something like u-label. I'd add the flag since the support is going away now (the dep was moved to optional in setup.py).

Closes: https://bugs.gentoo.org/678176
Package-Manager: Portage-2.3.60, Repoman-2.3.12
Signed-off-by: Craig Andrews <candrews@gentoo.org>
@candrews
Copy link
Member Author

idna may be useful, but I'd call the use flag something like u-label. I'd add the flag since the support is going away now (the dep was moved to optional in setup.py).

I used idna as the use flag name as I don't think this change is as much about u-label (according to https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst the u-label change was in 2.1 and was backwards incompatible). I may be mistaken; apologies if that's the case. Feel free to let me know and I can change the PR (but you may need to fill me in on what the metadata.xml use flag description should be).

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-02-17 16:00 UTC
Newest commit scanned: 7e512b3
Status: ✅ good

No issues found

@prometheanfire
Copy link
Member

nah, idna is fine, I didn't have a great preference.

@prometheanfire
Copy link
Member

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants