Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/xqilla: version bump to 2.3.4 #11179

Closed
wants to merge 1 commit into from
Closed

dev-libs/xqilla: version bump to 2.3.4 #11179

wants to merge 1 commit into from

Conversation

jok-ts
Copy link
Contributor

@jok-ts jok-ts commented Feb 28, 2019 •
edited

Closes: https://bugs.gentoo.org/672886

dev-libs/xqilla-2.3.3 doesn't compile against dev-libs/xerces-c-3.2.2-r1 which just went stable everywhere.
Version bump to a version that does, only the subslot and the xerces-c dependency have been changed.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 28, 2019
@jok-ts jok-ts force-pushed the gb_677238 branch 2 times, most recently from ef929b7 to 62de0a6 Compare February 28, 2019 22:51
@jok-ts jok-ts changed the title dev-libs/xqilla: version bump to 2.3.4 dev-libs/xqilla: version bump to 2.3.4 [please reassign] Feb 28, 2019
@gentoo-bot gentoo-bot changed the title dev-libs/xqilla: version bump to 2.3.4 [please reassign] dev-libs/xqilla: version bump to 2.3.4 Feb 28, 2019
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 28, 2019
@jok-ts jok-ts changed the title dev-libs/xqilla: version bump to 2.3.4 dev-libs/xqilla: version bump to 2.3.4 [please reassign] Apr 19, 2019
@gentoo-bot gentoo-bot changed the title dev-libs/xqilla: version bump to 2.3.4 [please reassign] dev-libs/xqilla: version bump to 2.3.4 Apr 19, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @jok-ts
Areas affected: ebuilds
Packages affected: dev-libs/xqilla

dev-libs/xqilla: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 671442, 672886

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 19, 2019
@juippis
Copy link
Member

juippis commented Apr 19, 2019

This package is masked,
5d40041

have you taken these into account (I see it at least doesn't depend on htmltidy anymore). Would you like to become the dedicated maintainer for it?

Ping @mgorny

mgorny
mgorny requested changes Apr 20, 2019
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include taking over maintenance and removing the p.mask (in separate commits).

dev-libs/xqilla/metadata.xml Outdated
@@ -7,6 +7,8 @@
certain tasks</flag>
<flag name="htmltidy">Use <pkg>app-text/htmltidy</pkg> when parsing
HTML</flag>
<flag name="tidy">Use <pkg>app-text/tidy-html5</pkg> when parsing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a global flag, so you don't need to describe it again.

dev-libs/xqilla/xqilla-2.3.4.ebuild Outdated
}

src_install () {
use doc && HTML_DOCS=( docs/{dev-api,dom3-api,simple-api} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make the var local.

dev-libs/xqilla/xqilla-2.3.4.ebuild Outdated
use doc && HTML_DOCS=( docs/{dev-api,dom3-api,simple-api} )
default

if ! use static-libs; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need .la files for static libs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, I just tried to do this with minimal changes to the existing ebuild.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include taking over maintenance and removing the p.mask (in separate commits).

I don't think I want to take over the maintenance.

@jok-ts
dev-libs/xqilla: version bump to 2.3.4
716dcd4 
Also, depend on app-text/tidy-html5 instead of app-text/htmltidy

Signed-off-by: Jouni Kosonen <jouni.kosonen@tukesoft.com>
Closes: https://bugs.gentoo.org/672886
Closes: https://bugs.gentoo.org/671442
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-21 00:56 UTC
Newest commit scanned: 716dcd4
Status: ✅ good

No issues found

@mgorny
Copy link
Member

mgorny commented Apr 21, 2019

I'm afraid in this case I don't see the purpose of merging this as primary last rite reason (lack of maintainer) still stands. Merging it would be just patch work that would result in some other issue setting up back for removal later on.

@jok-ts
Copy link
Contributor Author

jok-ts commented Apr 23, 2019

  • Unmaintained.
  • Fails to build.
  • Last bumped in 2016, and no new releases since.
  • Still depends on dead app-text/htmltidy (#671442).

Well, got three out of four sorted. I'll close this PR later.

@jok-ts
Copy link
Contributor Author

jok-ts commented May 18, 2019

Closing after package cleanup.

@jok-ts jok-ts closed this May 18, 2019
@jok-ts jok-ts deleted the gb_677238 branch May 18, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@jok-ts @gentoo-bot @juippis @gentoo-repo-qa-bot @mgorny