net-proxy/3proxy: Version bump to 0.8.12 #11220
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @powerman net-proxy/3proxy: Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
| # Copyright 1999-2019 Gentoo Authors | ||
| # Distributed under the terms of the GNU General Public License v2 | ||
|
|
||
| EAPI=6 |
There was a problem hiding this comment.
7 should work here (please test reinstalling after bumping)
There was a problem hiding this comment.
Done. If it's recommended for new ebuilds then why skel.ebuild contains EAPI=6?
There was a problem hiding this comment.
That's pretty interesting actually. If you make a new ebuild using vim, it gives you EAPI=7 and an empty BDEPEND line. But the /skel.ebuild has EAPI-6 indeed. Maybe the one in tree has been forgotten, or it's held back because some few eclasses don't support 7 yet. Still it does say:
# It is suggested that you use the latest EAPI approved by the Council.
I might open a bug about updating the /skel.ebuild, thanks!
| CC = gcc | ||
|
|
||
| -CFLAGS = -g -O2 -fno-strict-aliasing -c -pthread -DGETHOSTBYNAME_R -D_THREAD_SAFE -D_REENTRANT -DNOODBC -DWITH_STD_MALLOC -DFD_SETSIZE=4096 -DWITH_POLL | ||
| +CFLAGS = -fno-strict-aliasing -c -pthread -DGETHOSTBYNAME_R -D_THREAD_SAFE -D_REENTRANT -DNOODBC -DWITH_STD_MALLOC -DFD_SETSIZE=4096 -DWITH_POLL |
There was a problem hiding this comment.
It will not respect user's CFLAGS. Use += or something.
| +++ b/Makefile.Linux 2019-03-02 22:37:42.735259129 +0200 | ||
| @@ -10,11 +10,11 @@ | ||
| BUILDDIR = | ||
| CC = gcc |
There was a problem hiding this comment.
It will not respect user's $CC. Probably you need to use ?= here, and pass CC="$(tc-getCC)" to make.
| LN = gcc | ||
| DCFLAGS = -fpic | ||
| -LDFLAGS = -O2 -fno-strict-aliasing -pthread | ||
| +LDFLAGS = -fno-strict-aliasing -pthread |
Signed-off-by: Aleksandr Efros <powerman-asdf@yandex.ru> Package-Manager: Portage-2.3.51, Repoman-2.3.11
|
@steils I've applied changes related to your review and squashed commits. |
Pull request CI reportReport generated at: 2019-05-26 12:30 UTC No issues found |
|
Thanks. Pushed. However it was not enough to respect |
Signed-off-by: Aleksandr Efros powerman-asdf@yandex.ru
Package-Manager: Portage-2.3.51, Repoman-2.3.11