Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-games/physfs: backport patch to fix PHYSFS_setWriteDir #11231

Closed
wants to merge 3 commits into from

Conversation

steils
Copy link
Member

@steils steils commented Mar 3, 2019

There was a bug in PHYSFS_setWriteDir() that caused creating an empty
file "$HOME/.lincity-ng" instead of a directory on the first run of
lincity-ng:
lincity-ng/lincity-ng#25

The upstream patch is added to <stable-3.0> branch but no release is
made so far. Backport it.

Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @steils
Areas affected: ebuilds
Packages affected: dev-games/physfs

dev-games/physfs: @gentoo/games

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 3, 2019
There was a bug in PHYSFS_setWriteDir() that caused creating an empty
file "$HOME/.lincity-ng" instead of a directory on the first run of
lincity-ng:
lincity-ng/lincity-ng#25

The upstream patch is added to <stable-3.0> branch but no release is
made so far. Backport it.

Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-04 03:59 UTC
Newest commit scanned: f9a569f
Status: ✅ good

All QA issues have been fixed!

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chewi
Copy link
Member

chewi commented Mar 4, 2019

I needed to make a couple more changes but it's merged now. Thanks!

@gentoo-bot gentoo-bot closed this in 248251b Mar 4, 2019
@steils steils deleted the physfs branch March 6, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants