Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 #11235

Closed
wants to merge 1 commit into from
Closed

games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 #11235

wants to merge 1 commit into from

Conversation

steils
Copy link
Member

@steils steils commented Mar 3, 2019 •
edited

Drop games eclass; update homepage, SRC_URI and licenses; some minor and
stylistic changes.

Closes: https://bugs.gentoo.org/604618
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 3, 2019
chewi
chewi suggested changes Mar 3, 2019
View reviewed changes
games-simulation/lincity-ng/lincity-ng-2.9_beta.ebuild
default
sed -i "/COPYING COPYING-data.txt COPYING-fonts.txt CREDITS /d" \
Jamfile || die
./autogen.sh || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen exactly what this autogen script does but you should use eautoreconf from autotools eclass if that works instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried. Unfortunately eautoreconf does not work here. autogen.sh runs aclocal, autoheader, then generates Jamconfig.in which is needed for configure and then runs autoconf.
Generating Jamconfig.in could be done in src_prepare by hand. But should it?

games-simulation/lincity-ng/lincity-ng-2.9_beta.ebuild Show resolved Hide resolved
@steils steils force-pushed the lincity branch 3 times, most recently from c54633d to 7e1dcca Compare March 4, 2019 01:55
@steils
Copy link
Member Author

steils commented Mar 4, 2019

@chewi, @juippis, thank you for the thorough review! I think I made all the requested changes but autogen.sh. Please tell me if you find anything else:)

@steils steils changed the title games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 [please reassign] Mar 4, 2019
@gentoo-bot gentoo-bot changed the title games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 [please reassign] games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7 Mar 4, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @steils
Areas affected: ebuilds
Packages affected: games-simulation/lincity-ng

games-simulation/lincity-ng: @gentoo/games

Linked bugs

Bugs linked: 604618

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 4, 2019
juippis
juippis approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If you follow the default skel, there's always an empty line below EAPI, but I wouldn't hold this because of that. Just something to keep in mind for future ;)

@steils
Copy link
Member Author

steils commented Mar 4, 2019

LGTM!

If you follow the default skel, there's always an empty line below EAPI, but I wouldn't hold this because of that. Just something to keep in mind for future ;)

Eh. Thanks. I know that but sometimes forget it when I rewrite ebuilds from previous versions...

@steils
games-simulation/lincity-ng: bump version to 2.9_beta; EAPI=7
2b28bd7 
Drop games eclass; update homepage, SRC_URI and licenses; fix prefixed
install; some minor and stylistic changes.

Closes: https://bugs.gentoo.org/604618
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-04 14:18 UTC
Newest commit scanned: 2b28bd7
Status: ✅ good

No issues found

@chewi chewi self-assigned this Mar 5, 2019
@gentoo-bot gentoo-bot closed this in bed5ab3 Mar 6, 2019
@steils steils deleted the lincity branch March 6, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r left review comments

@chewi chewi chewi requested changes

@juippis juippis juippis approved these changes

Assignees

@chewi chewi

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
6 participants
@steils @gentoo-bot @gentoo-repo-qa-bot @chewi @a17r @juippis