Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FreeRadius 3.0.18 and bugfix #11304

Closed
wants to merge 3 commits into from
Closed

Bump FreeRadius 3.0.18 and bugfix #11304

wants to merge 3 commits into from

Conversation

geaaru
Copy link
Contributor

@geaaru geaaru commented Mar 8, 2019

  • Drop v.3.0.15
  • Fix issue #675230
  • Bump v.3.0.18

@geaaru
net-dialup/freeradius: Drop v.3.0.15
3eafcff 
Package-Manager: Portage-2.3.51, Repoman-2.3.12
Signed-off-by: Daniele Rondina <geaaru@gmail.com>
@geaaru
net-dialup/freeradius: Drop libtool from RDEPEND
30e1064 
Closes: https://bugs.gentoo.org/675230
Package-Manager: Portage-2.3.51, Repoman-2.3.12
Signed-off-by: Daniele Rondina <geaaru@gmail.com>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @geaaru
Areas affected: ebuilds
Packages affected: net-dialup/freeradius

net-dialup/freeradius: @geaaru, @gentoo/proxy-maint

Linked bugs

Bugs linked: 675230

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 8, 2019
monsieurp
monsieurp suggested changes Mar 10, 2019
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments. Thanks for your contribution!

net-dialup/freeradius/freeradius-3.0.18.ebuild Outdated

dodoc CREDITS

rm "${D}/usr/sbin/rc.radiusd" || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you perform this operation at the very beginning of the src_install function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, np.

net-dialup/freeradius/freeradius-3.0.18.ebuild Outdated
systemd_newtmpfilesd "${FILESDIR}"/freeradius.tmpfiles freeradius.conf
systemd_dounit "${FILESDIR}"/freeradius.service

find "${ED}" \( -name "*.a" -o -name "*.la" \) -delete || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think if I replace find "${ED}"... with prune_libtool_files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

net-dialup/freeradius/freeradius-3.0.18.ebuild Outdated
cd "${ROOT}"/etc/raddb/certs
./bootstrap

chown -R root:radius "${ROOT}"/etc/raddb/certs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using fowners here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) probably it's a legacy row of the previous maintainer. I will fix it. Thanks

monsieurp
monsieurp suggested changes Mar 10, 2019
View reviewed changes
net-dialup/freeradius/freeradius-3.0.18.ebuild Outdated Show resolved Hide resolved
net-dialup/freeradius/freeradius-3.0.18.ebuild Outdated Show resolved Hide resolved
@geaaru
net-dialup/freeradius: Bump v.3.0.18
f99b527 
Signed-off-by: Daniele Rondina <geaaru@gmail.com>
Package-Manager: Portage-2.3.51, Repoman-2.3.12
monsieurp
monsieurp approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! The ebuilds looks good now. Thank you for your corrections and your contribution! Merging underway.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-10 23:22 UTC
Newest commit scanned: f99b527
Status: ✅ good

No issues found

@stikonas
Copy link
Contributor

Why was stable version dropped? I see no explanation in commit message.

@geaaru
Copy link
Contributor Author

geaaru commented Mar 12, 2019

Because there are a lot of bugfixes in the releases 3.0.{16,17,18} and I don't consider 3.0.15 as stable. I move 3.0.17 (that I have in production from at least one year) as stable.
I try to create stabilization issue in these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurp monsieurp monsieurp approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@geaaru @gentoo-bot @gentoo-repo-qa-bot @stikonas @monsieurp