Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-block/targetcli-fb: bump to 2.1.49 #11336

Closed
wants to merge 3 commits into from
Closed

sys-block/targetcli-fb: bump to 2.1.49 #11336

wants to merge 3 commits into from

Conversation

diogocp
Copy link
Contributor

@diogocp diogocp commented Mar 10, 2019

No description provided.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @diogocp
Areas affected: ebuilds
Packages affected: sys-block/targetcli-fb

sys-block/targetcli-fb: @diogocp, @gentoo/proxy-maint

Linked bugs

Bugs linked: 657610

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 10, 2019
monsieurp
monsieurp previously requested changes Mar 10, 2019
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wait. Who is Maurizio Lombardi and why are you adding him to the metadata.xml file out of the blue?

@diogocp
Copy link
Contributor Author

diogocp commented Mar 10, 2019

Upstream maintainer.

@monsieurp
Copy link
Member

He has no account on https://bugs.gentoo.org.

@diogocp
Copy link
Contributor Author

diogocp commented Mar 12, 2019

Yeah, he is an upstream maintainer. Same as Andy Grover (who doesn't seem very active anymore).

@monsieurp
Copy link
Member

Great! Nonetheless he still has no account on https://bugs.gentoo.org. Please get him to create one so that he can be assigned bugs.

@monsieurp
Copy link
Member

@diogocp: Hi! Is Maurrizio willing to create an account? This PR won't be merged until he does so.

@juippis
Copy link
Member

juippis commented Mar 19, 2019

I think the question here is: Do you have his consent on being added here as a ebuild maintainer, or did you just add him because he's the upstream maintainer? Does he even use Gentoo?

@diogocp
Copy link
Contributor Author

diogocp commented Mar 19, 2019

I did not add him as an ebuild maintainer. I added him to the upstream section because he is an upstream maintainer. He is not supposed to get assigned Gentoo bugs. I've done the same in several other packages and there was never a problem.

Anyway, I won't have access to a computer until next week, so I won't be touching this until then.

@monsieurp
Copy link
Member

I've done the same in several other packages and there was never a problem.

Well that's actually a problem. Email addresses in metadata.xml files are meant to be linked to Gentoo Bugzilla accounts for bug assignments. Why? Gentoo bug wranglers read this file when a bug against a package is filed. Again, I'm not trying to be a PITA, I just want to avoid a situation in which we've got to deal with a bug but there's no maintainer to talk to. It happened before and we would like it not to happen again.

@mgorny mgorny dismissed monsieurp’s stale review April 19, 2019 21:35

it's in section

@mgorny
Copy link
Member

mgorny commented Apr 19, 2019

I'm sorry about the mistake here. Could you rebase this?

@diogocp
sys-block/targetcli-fb: bump to 2.1.49
5b6a898 
Closes: https://bugs.gentoo.org/657610
Signed-off-by: Diogo Pereira <sir.suriv@gmail.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@diogocp
sys-block/targetcli-fb: update metadata
8c68594 
Signed-off-by: Diogo Pereira <sir.suriv@gmail.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@diogocp
sys-block/targetcli-fb: drop old
862be3b 
Signed-off-by: Diogo Pereira <sir.suriv@gmail.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@diogocp
Copy link
Contributor Author

diogocp commented Apr 21, 2019

Rebased, thanks.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-21 22:36 UTC
Newest commit scanned: 862be3b
Status: ✅ good

All QA issues have been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurp monsieurp monsieurp left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
6 participants
@diogocp @gentoo-bot @monsieurp @juippis @mgorny @gentoo-repo-qa-bot