Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/cssutils: add support for Python3.7, EAPI 7 #11354

Closed
wants to merge 2 commits into from
Closed

dev-python/cssutils: add support for Python3.7, EAPI 7 #11354

wants to merge 2 commits into from

Conversation

arthurzam
Copy link
Member

Updated this new ebuild to EAPI=7
Added support for Python3.7

I put the bug for dev-python/cssutils a week ago, without any response. So now I try to put up a Pull Request.
This Pull Request is needed for #11264.

Closes: https://bugs.gentoo.org/679494
Package-Manager: Portage-2.3.62, Repoman-2.3.12

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @arthurzam
Areas affected: ebuilds
Packages affected: dev-python/cssutils

dev-python/cssutils: @LordVan, @gentoo/python

Linked bugs

Bugs linked: 679494

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 13, 2019
@juippis
Copy link
Member

juippis commented Mar 13, 2019

EAPI bump requires a revbump for the ebuild (-r1), while adding python3.7 doesn't. I'd recommend you to just add python3.7 without bumping EAPI.

And make sure you run tests / the python executable with python3.7 to test it :P

monsieurp
monsieurp suggested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You must revbump the ebuild. Inline EAPI bumps are a no-go. The rest is fine. 👍

@arthurzam
Copy link
Member Author

@juippis @monsieurp Thanks for your feedback.
I have added -r1 to the ebuild. I have moved the file to the new revision, instead of saving the previous version without the revbump 1.0.2 -> 1.0.2-r1. Is it OK?

@juippis
Copy link
Member

juippis commented Mar 14, 2019

I think in this case it's ok, but usually you want to make a new file and remove the old file with 2nd commit. It makes reverting changes easier, and better for users who might have trouble compiling the -r1 ebuild.

@arthurzam
dev-python/cssutils: add support for Python3.7, EAPI 7
ebca153 
Closes: https://bugs.gentoo.org/679494
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
dev-python/cssutils: remove 1.0.2 (r0)
878c4b7 
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
Copy link
Member Author

arthurzam commented Mar 19, 2019 •
edited

Well, after 5 days without reply, I guess it isn't OK in this PR.
I divided into adding version r1, and removing version r0

What is needed to merge it?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-19 17:58 UTC
Newest commit scanned: 878c4b7
Status: ✅ good

No issues found

monsieurp
monsieurp approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not picking it up earlier. Merging underway. Thanks!

@arthurzam arthurzam deleted the dev-python/cssutils branch March 21, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurp monsieurp monsieurp approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@arthurzam @gentoo-bot @juippis @gentoo-repo-qa-bot @monsieurp