Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag #11555

Closed
wants to merge 4 commits into from
Closed

dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag #11555

wants to merge 4 commits into from

Conversation

Phoenix591
Copy link
Contributor

Please provide feedback, I'd like to get this package back up to date

@Phoenix591
dev-util/idea-community: 2018.3.4 version bump
d42af6f 
(identical to 2018.3.3 ebuild)

Package-Manager: Portage-2.3.59, Repoman-2.3.12
Signed-off-by: Kyle Elbert <kcelbert@gmail.com>
Bug: https://bugs.gentoo.org/676900
Bug: https://bugs.gentoo.org/653144
Bug: https://bugs.gentoo.org/640688
@Phoenix591
dev-util/idea-community: Fetch the custom-jdk seperately
f252c7e 
Reduces download size for USE -custom-jdk and fixes USE custom-jdk for x86

Bug: https://bugs.gentoo.org/676370
Package-Manager: Portage-2.3.59, Repoman-2.3.12
Signed-off-by: Kyle Elbert <kcelbert@gmail.com>
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Mar 31, 2019
@Phoenix591 Phoenix591 changed the title dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag [please reassign] dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag Mar 31, 2019
@gentoo-bot gentoo-bot changed the title [please reassign] dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag dev-util/idea community: version 2019.1 version bump, split custom-jdk useflag Mar 31, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @Phoenix591
Areas affected: ebuilds
Packages affected: dev-util/idea-community

dev-util/idea-community: @aliceinwire

Linked bugs

Bugs linked: 653144, 676370, 676900, 640688

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Mar 31, 2019
@arthurzam
Copy link
Member

I think you can change in the commit message from Bug: ##### to Closes: #####, because it looks like in case this PR merges those bugs are closed. Using the Closes: will auto close the bugs when merged.

@Phoenix591
dev-util/idea-community: bump to 2019.1 and Split custom-jdk useflag
53c016c 
Upstream now offers a Java 11 based Jetbrains Runtime,
while continuing to offer their Java 8 based runtime as the default download

Closes: https://bugs.gentoo.org/653144
Closes: https://bugs.gentoo.org/676370
Closes: https://bugs.gentoo.org/676900
Closes: https://bugs.gentoo.org/640688
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Kyle Elbert <kcelbert@gmail.com>
@Phoenix591
dev-util/idea-community: drop old version
126f142 
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Kyle Elbert <kcelbert@gmail.com>
@Phoenix591
Copy link
Contributor Author

I think you can change in the commit message from Bug: ##### to Closes: #####, because it looks like in case this PR merges those bugs are closed. Using the Closes: will auto close the bugs when merged.

Hmm, looks like that's the case, repoman just talks about pull requests when referring to the closes tag

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-31 09:15 UTC
Newest commit scanned: 126f142
Status: ✅ good

No issues found

@aliceinwire aliceinwire self-assigned this Apr 9, 2019
@gentoo-bot gentoo-bot closed this in 0ba08d5 Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aliceinwire aliceinwire

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@Phoenix591 @gentoo-bot @arthurzam @gentoo-repo-qa-bot @aliceinwire