Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/webstorm: bump to 2019.1 #11613

Closed
wants to merge 3 commits into from
Closed

dev-util/webstorm: bump to 2019.1 #11613

wants to merge 3 commits into from

Conversation

jarreskng
Copy link

  1. version bump to 2019.1, EAPI=7
  2. custom-jdk use flag

@jarreskng
dev-util/webstorm: version bump to 2019.1
45411c0 
Closes: https://bugs.gentoo.org/682704
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Mikhail Titov <jarreskng@gmail.com>
@jarreskng
dev-util/webstorm: add custom-jdk use flag
abfb270 
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Mikhail Titov <jarreskng@gmail.com>
@jarreskng
dev-util/webstorm: add fs.inotify.max_user_watches option
3a63f55 
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Mikhail Titov <jarreskng@gmail.com>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @jarreskng
Areas affected: ebuilds
Packages affected: dev-util/webstorm

dev-util/webstorm: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 682704

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 6, 2019
@jarreskng jarreskng changed the title Dev util/webstorm dev-util/webstorm: bump to 2019.1 Apr 6, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-06 19:35 UTC
Newest commit scanned: 3a63f55
Status: ✅ good

No issues found

juippis
juippis reviewed Jul 31, 2019
View reviewed changes
dev-util/webstorm/webstorm-2019.1.191.6183.63.ebuild
LICENSE="IDEA || ( IDEA_Academic IDEA_Classroom IDEA_OpenSource IDEA_Personal )"

KEYWORDS="~amd64 ~x86"
SLOT="2019"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this install parallel to previous slot without collisions? If not, use the previous slot.

dev-util/webstorm/metadata.xml
@@ -5,4 +5,7 @@
<longdescription lang="en">
WebStorm is a lightweight yet powerful IDE, perfectly equipped for complex client-side development and server-side development with Node.js
</longdescription>
<use>
<flag name="custom-jdk">Install and use WebStorm's custom JRE.</flag>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence-ending dot can be removed from here.

dev-util/webstorm/Manifest
@@ -1 +1,2 @@
DIST WebStorm-2017.2.4.tar.gz 257748171 BLAKE2B 2b0951e94f92a0d690bf9261573963dd6250d9b896784b7156dde8b39ec3a59f94da023bcd3183b404e4bfa16d27928d3eecedf54f5b9036e856af5237e8c5ed SHA512 283339f7757093affde698cfb751f7ced18d54159db7696c9fe6b4d37751e94ad1ca9f0c54db9d5ca256da35ee24454a3b48ced21d6db434c23ec94b023a4d09
DIST webstorm-2019.1.191.6183.63.tar.gz 267639462 BLAKE2B 3a5a6a88104d65e31c21b3298d493b270f425ed7835eac2450c4f5bb7a8cee994d2b61c1448f86d3c8f436467cde3c525d88bf74cc9117e4a7c2ba0139d1a935 SHA512 8b6bd491041b061045e8ba8dbc950c534035617d510a7f8e59be17e7fa7d425843fb3dfde7a67f081a5125faa75302fbb21692648f2f686761f3b125f75b2f6a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this whole ebuild be versioned like webstorm-2019.1.191, do the latter numbers change often, and are they packaged?

dev-util/webstorm/webstorm-2019.1.191.6183.63.ebuild

declare -a remove_me

use arm || remove_me+=( bin/fsnotifier-arm )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if its wiser to remove these conditionally, or fix doins...

@juippis
Copy link
Member

juippis commented Jul 31, 2019

If you'd like to maintain this package, add yourself and proxy-maint project to metadata.xml file too.

@juippis
Copy link
Member

juippis commented Feb 19, 2020

Looks like this was removed from the tree.

@juippis juippis closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@jarreskng @gentoo-bot @gentoo-repo-qa-bot @juippis