Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail-filter/opendkim: Removed 'gnutls' support, added enewgroup #11711

Closed
wants to merge 1 commit into from
Closed

mail-filter/opendkim: Removed 'gnutls' support, added enewgroup #11711

wants to merge 1 commit into from

Conversation

rseichter
Copy link
Contributor

Switched to IUSE="-gnutls" to address bug 682906. @orlitzky I hope this is the right method to do it?

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 16, 2019
@orlitzky
Copy link
Contributor

The negative sign is actually implied already. It would be nice if we could fix the patch to work with the new version of gnutls, but for now, it's probably best just to disable it:

  • Delete the USE flag entirely
  • Drop the patch
  • Remove the use_with line

(basically, just search the ebuild for "gnutls" and kill everything you find.)

Please also add an enewgroup opendkim for the bug that I'm about to assign to us.

@rseichter
mail-filter/opendkim: Removed 'gnutls' support, added enewgroup
27d9475 
Removed support for the 'gnutls' use flag. Added missing enewgroup
statement. These modifications address the two bugs listed below.

Closes: https://bugs.gentoo.org/682906
Closes: https://bugs.gentoo.org/683338
Signed-off-by: Ralph Seichter <gentoo@seichter.de>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@rseichter rseichter changed the title mail-filter/opendkim: Disabled gnutls in IUSE mail-filter/opendkim: Removed 'gnutls' support, added enewgroup [please reassign] Apr 16, 2019
@gentoo-bot gentoo-bot changed the title mail-filter/opendkim: Removed 'gnutls' support, added enewgroup [please reassign] mail-filter/opendkim: Removed 'gnutls' support, added enewgroup Apr 16, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @rseichter
Areas affected: ebuilds
Packages affected: mail-filter/opendkim

mail-filter/opendkim: @rseichter, @klondi, @orlitzky, @gentoo/proxy-maint

Linked bugs

Bugs linked: 682906, 683338

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Apr 16, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-16 22:57 UTC
Newest commit scanned: 27d9475
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/838aad3/output.html#app-crypt/princeprocessor

@orlitzky
Copy link
Contributor

Pulled, thanks!

@orlitzky orlitzky closed this Apr 16, 2019
@rseichter rseichter deleted the opendkim190416 branch April 17, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@rseichter @orlitzky @gentoo-bot @gentoo-repo-qa-bot