Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-cdr/cdw: EAPI=7 bump #11729

Closed
wants to merge 4 commits into from
Closed

app-cdr/cdw: EAPI=7 bump #11729

wants to merge 4 commits into from

Conversation

arthurzam
Copy link
Member

  • EAPI=7 bump
  • fix dependency on dev-libs/libcdio - need to rebuild on sub-SLOT change.
  • updated both live version and regular version (bumped r0 -> r1)

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @arthurzam
Areas affected: ebuilds
Packages affected: app-cdr/cdw

app-cdr/cdw: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 18, 2019
@mgorny
Copy link
Member

mgorny commented Apr 22, 2019

Would you be interested in becoming the maintainer for this package?

@arthurzam
Copy link
Member Author

@mgorny Yes, will be glad.
Should I just add myself as a proxy-maintainer in metadata.xml?

@mgorny
Copy link
Member

mgorny commented Apr 22, 2019

Please do. Also please verify the license in case you didn't do that, https://devmanual.gentoo.org/general-concepts/licenses/index.html#gpl-x-vs-gpl-x+

@arthurzam
app-cdr/cdw: EAPI=7 bump
217406e 
bump to EAPI=7
fix rebuild on SLOT for dev-libs/libcdio

Package-Manager: Portage-2.3.63, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
app-cdr/cdw: EAPI=7 bump for live
4b8bc1f 
bump to EAPI=7
fix rebuild on SLOT for dev-libs/libcdio

Package-Manager: Portage-2.3.63, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
app-cdr/cdw: fix license to GPL-2+
cdda481 
Package-Manager: Portage-2.3.64, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
app-cdr/cdw: set new proxy maintainer
d87abdc 
Package-Manager: Portage-2.3.64, Repoman-2.3.12
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@arthurzam
Copy link
Member Author

@mgorny Thank you - have done all.
Found out it was really GPL-2+ as you suspected. Added the third commit to fix the stable ebuild.
Added a new commit setting myself in metadata.xml

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-22 16:57 UTC
Newest commit scanned: d87abdc
Status: ✅ good

No issues found

@mgorny
Copy link
Member

mgorny commented Apr 22, 2019

Thanks a lot. I'm going to reorder the commit a bit to have license change first, since all the remaining commits already have the correct license.

@arthurzam arthurzam deleted the app-cdr/cdw-eapi7 branch April 23, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoapGentoo SoapGentoo SoapGentoo approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@arthurzam @gentoo-bot @mgorny @gentoo-repo-qa-bot @SoapGentoo