Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install location of cuda binaries. #11735

Closed
wants to merge 2 commits into from
Closed

Fix install location of cuda binaries. #11735

wants to merge 2 commits into from

Conversation

jvesely
Copy link
Contributor

@jvesely jvesely commented Apr 18, 2019 •
edited

Turns out running pycuda was no the best test.
I didn't find a better way to do a recursive install of executables. Let me know if I missed something.

@jvesely
Copy link
Contributor Author

jvesely commented Apr 18, 2019

@perfinion , does this help with the tensorflow situation?

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @jvesely
Areas affected: ebuilds
Packages affected: dev-util/nvidia-cuda-toolkit

dev-util/nvidia-cuda-toolkit: @gentoo/sci

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 18, 2019
@jvesely
Copy link
Contributor Author

jvesely commented Apr 25, 2019

ping.
This also fixes installed nvcc.

@heroxbd
Copy link
Contributor

heroxbd commented Apr 26, 2019 •
edited

@jvesely, Thanks! Could you please explain in your commit message why nvcc is broken and why your patch fixes it?

@jvesely
dev-util/nvidia-cuda-toolkit-10.1.105: Fix installation location of e…
34aa360 
…xecutables

link.stub and prelink.stub need to be in crt subdirectory otherwise nvcc
fails to find them.
Fixes failures when invoking nvcc.

Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
@jvesely
dev-util/nvidia-cuda-toolkit: Remove broken version
57aba1a 
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
@jvesely
Copy link
Contributor Author

jvesely commented Apr 26, 2019 •
edited

@jvesely, Thanks! Could you please explain in your commit message why nvcc is broken and why your patch fixes it?

Added. The contents of bin/ directory need to be installed recursively in correct subdirs, otherwise nvcc fails to find crt/link.stub or crt/prelink.stub.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-04-26 03:58 UTC
Newest commit scanned: 57aba1a
Status: ✅ good

No issues found

@perfinion perfinion self-assigned this Apr 28, 2019
@perfinion
Copy link
Member

I made some changes from this patch and the one on bugzilla and also fixed extras/demo_suite (tensorflow uses deviceQuery)

commit ae90e7d8c2d34aed7961f2de107959cb8605559c
Author: Jason Zaman <perfinion@g.o>
Date:   Mon Apr 29 21:22:00 2019

    dev-util/nvidia-cuda-toolkit-10.1.105: Fix installation location of executables
    
    Fixes failures when invoking nvcc. link.stub and prelink.stub need to be
    in crt subdirectory otherwise nvcc fails to find them.
    Also extras/demo_suite were not executable.
    
    Thanks to Jan Vesely and Nathaniel R. Lewis, this fix was derived from
    patches from them.
    
    Closes: https://github.com/gentoo/gentoo/pull/11735
    Closes: https://bugs.gentoo.org/684392
    Signed-off-by: Jason Zaman <perfinion@g.o>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11

@perfinion perfinion closed this Apr 29, 2019
gentoo-bot pushed a commit that referenced this pull request Apr 29, 2019
@perfinion
dev-util/nvidia-cuda-toolkit-10.1.105: Fix installation location of e…
ae90e7d 
…xecutables

Fixes failures when invoking nvcc. link.stub and prelink.stub need to be
in crt subdirectory otherwise nvcc fails to find them.
Also extras/demo_suite were not executable.

Thanks to Jan Vesely and Nathaniel R. Lewis, this fix was derived from
patches from them.

Closes: #11735
Closes: https://bugs.gentoo.org/684392
Signed-off-by: Jason Zaman <perfinion@gentoo.org>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@jvesely jvesely deleted the cuda branch April 29, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@perfinion perfinion

Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@jvesely @gentoo-bot @heroxbd @gentoo-repo-qa-bot @perfinion