Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-action/supertuxkart: bump to 1.0 #11865

Closed
wants to merge 2 commits into from
Closed

games-action/supertuxkart: bump to 1.0 #11865

wants to merge 2 commits into from

Conversation

fx-carton
Copy link
Contributor

No description provided.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 30, 2019
@fx-carton fx-carton changed the title games-action/supertuxkart: bump to 1.0 [please reassign]games-action/supertuxkart: bump to 1.0 Apr 30, 2019
@gentoo-bot gentoo-bot changed the title [please reassign]games-action/supertuxkart: bump to 1.0 games-action/supertuxkart: bump to 1.0 Apr 30, 2019
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @fx-carton
Areas affected: ebuilds
Packages affected: games-action/supertuxkart

games-action/supertuxkart: @gentoo/games

Linked bugs

Bugs linked: 683930

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 30, 2019
juippis
juippis reviewed Apr 30, 2019
View reviewed changes
games-action/supertuxkart/supertuxkart-1.0.ebuild Outdated Show resolved Hide resolved
games-action/supertuxkart/supertuxkart-1.0.ebuild
recorder? ( media-libs/libopenglrecorder )
wiimote? ( net-wireless/bluez )"
DEPEND="${RDEPEND}
sys-devel/gettext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With EAPI-7, this and pkgconfig are BDEPEND. So something like:

RDEPEND="
	dev-libs/angelscript
	media-libs/glew:0=
	media-libs/libpng:0=
	media-libs/libvorbis
	media-libs/openal
	net-libs/enet:1.3=
	net-misc/curl
	sys-libs/zlib
	virtual/glu
	virtual/jpeg:0
	virtual/libintl
	virtual/opengl
	x11-libs/libX11
	x11-libs/libXxf86vm
	fribidi? ( dev-libs/fribidi )
	nettle? ( dev-libs/nettle )
	openssl? ( dev-libs/openssl:0= )
	recorder? ( media-libs/libopenglrecorder )
	wiimote? ( net-wireless/bluez )"
DEPEND="${RDEPEND}"
BDEPEND="
	sys-devel/gettext
	virtual/pkgconfig"

zlib is unnecessary dependency as its part of every system profile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it isn't, at least not directly.

games-action/supertuxkart/supertuxkart-1.0.ebuild Outdated Show resolved Hide resolved
games-action/supertuxkart/supertuxkart-1.0.ebuild Outdated Show resolved Hide resolved
@fx-carton
Copy link
Contributor Author

It seems EAPI 7 enabled shared libs by default on CMake. That makes the bundled dependency libsquish a shared library, which is not installed in the install phase for some reason.

I believe it is cleaner to build libsquish as a static library, because the package is supertuxkart and should not install libraries in /usr/lib. That's the approach I've taken by adding -DBUILD_SHARED_LIBS=OFF with a comment.

juippis
juippis approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * /tmp/portage/games-action/supertuxkart-1.0/work/supertuxkart-1.0/lib/bullet/src/BulletDynamics/Vehicle/btWheelInfo.h:38:8: warning: '<anonymous>.btWheelInfo::m_raycastInfo' is used uninitialized in this function [-Wuninitialized]
 * /tmp/portage/games-action/supertuxkart-1.0/work/supertuxkart-1.0/lib/bullet/src/LinearMath/btMatrix3x3.h:63:11: warning: '*((void*)(&<anonymous>)+104).btMatrix3x3::m_el[0]' is used uninitialized in this function [-Wuninitialized]
 * /tmp/portage/games-action/supertuxkart-1.0/work/supertuxkart-1.0/lib/bullet/src/LinearMath/btMatrix3x3.h:64:11: warning: '*((void*)(&<anonymous>)+104).btMatrix3x3::m_el[1]' is used uninitialized in this function [-Wuninitialized]
 * /tmp/portage/games-action/supertuxkart-1.0/work/supertuxkart-1.0/lib/bullet/src/LinearMath/btMatrix3x3.h:65:11: warning: '*((void*)(&<anonymous>)+104).btMatrix3x3::m_el[2]' is used uninitialized in this function [-Wuninitialized]
 * /tmp/portage/games-action/supertuxkart-1.0/work/supertuxkart-1.0/lib/bullet/src/LinearMath/btTransform.h:65:26: warning: '*((void*)(&<anonymous>)+104).btTransform::m_origin' is used uninitialized in this function [-Wuninitialized]
 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: https://supertuxkart.net/

but doesn't seem you can do much in the ebuild. Would be nice if it got reported upstream though.

I played it for a good 30 minutes without any issues. As a Crash Team Racing fan, this was rather fun. Thanks :)

@chewi chewi self-assigned this May 3, 2019
@fx-carton
Copy link
Contributor Author

Sorry for the delay, didn't get the notification for some reason. Will work on this.

@fx-carton
games-action/supertuxkart: bump to 1.0
763601f 
- Unbundle angelscript
- New deps nettle || openssl

Package-Manager: Portage-2.3.62, Repoman-2.3.11
Closes: https://bugs.gentoo.org/683930
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
@fx-carton
games-action/supertuxkart: EAPI 7
c9cbad0 
Package-Manager: Portage-2.3.62, Repoman-2.3.11
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
@fx-carton
Copy link
Contributor Author

All done. Tested with nettle and openssl, but not libressl.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-05-10 03:20 UTC
Newest commit scanned: c9cbad0
Status: ✅ good

No issues found

@chewi
Copy link
Member

chewi commented May 10, 2019

Awesome, thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewi chewi chewi approved these changes

@juippis juippis juippis approved these changes

Assignees

@chewi chewi

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@fx-carton @gentoo-bot @gentoo-repo-qa-bot @chewi @juippis