app-laptop/msi-keyboard: New package #11884
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @Fulgurance app-laptop/msi-keyboard: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
|
Hey, I see you have multiple PRs open for new packages. None of them really comply with our guidelines. First of all, you need to sign-off all your commits, then those commits need to be formatted to follow style, Also please follow the default skel type to keep unified and dont make ebuild phase functions multi-liners. So (example) If you still wish to work on these ebuilds, please update them, or open new PRs! It'd be nice if you rebased against fresh ::gentoo master. |
|
Okay, thanks for your advices. If in my next commit i sign off, is it good or i need to edit all of my commits ? |
|
You need to rebase and amend your previous commits, adding sign-off to every commit you make. You can automate it in the future by adding |
|
How can I edit my previous commit ? I don’t see any edit button. Screenshot ? |
|
You use git-tools from the command line. Don't use Github web UI. |
Fulgurance
force-pushed
the
msi-keyboard
branch
from
4753432
to
618f47f
Compare
|
It's good, i have signed all of my commits. Just i need to update now my ebuild. Ask me if you have any problem wit my edited commits |
|
Why i have this errors ? |
|
Your copy of master branch is too old, please update the master branch and then rebase mksi-keyboard against that, then force-push an update. |
Fulgurance
force-pushed
the
msi-keyboard
branch
from
618f47f
to
5a5ba63
Compare
|
I think now it's good :) |
|
I have little question, after my package was accepted, can i have rights to write documentation for my package in Gentoo web site documentation ? |
|
Now, please rebase and squash your commits into one, while following guidelines written in here: https://www.gentoo.org/glep/glep-0066.html#commit-messages
Yes, having a wiki page for it would be nice. |
|
I don't understand. Do i need to make just one commit for all of my commits ? |
|
Yes please, all this should happen within a single commit. Also your sign-off is missing |
Fulgurance
force-pushed
the
msi-keyboard
branch
from
3523687
to
1bd042b
Compare
|
Is it good ?:) |
app-laptop/msi-keyboard/metadata.xml
Outdated
| <maintainer type="person"> | ||
| <email>zohran.londais@gmail.com</email> | ||
| </maintainer> | ||
| <longdescription lang="en"> |
There was a problem hiding this comment.
You'll need to add someone with @gentoo.org email to commit for you. It's usually the proxy-maint project,
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml
Check examples from other proxy-maintained ebuilds.
There was a problem hiding this comment.
Can i add anybody, or i need to ask somebody if he is agree to commit for me ?
There was a problem hiding this comment.
Yes, you need your committers consent. If you dont have anyone in mind, add the proxy-maint project (see the link I gave you above)
app-laptop/msi-keyboard/metadata.xml
Outdated
| <email>zohran.londais@gmail.com</email> | ||
| </maintainer> | ||
| <longdescription lang="en"> | ||
| Control backlight of MSI laptop keyboards without node.js |
There was a problem hiding this comment.
This isn't really any longer than the default description and should be dropped.
| PATCHES=( | ||
| "${FILESDIR}"/${P}-cflags.patch | ||
| ) | ||
| SRC_URI="https://github.com/makkarpov/msi-keyboard/archive/v${PV}.tar.gz -> ${P}.tar.gz" |
There was a problem hiding this comment.
Your variables are all over the place, could you follow the default skel style?
https://github.com/gentoo/gentoo/blob/master/skel.ebuild
# Copyright 2019 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=7
DESCRIPTION=""
HOMEPAGE=""
SRC_URI=""
LICENSE=""
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE=""
DEPEND=""
RDEPEND="${DEPEND}"
BDEPEND=""
|
Then, you still don't follow the commit guidelines of https://gitweb.gentoo.org/repo/gentoo.git/log/ should also give you examples how to correctly format your git summary, and there's a lot of "spam" in your git message log :) |
Fulgurance
force-pushed
the
msi-keyboard
branch
from
d9e7eb0
to
bc01e57
Compare
|
I think now it's good :) |
|
Almost! Nearly there :) You may have to add a patch for Makefile to respect LDFLAGS from users make.conf. |
|
|
||
| RDEPEND="dev-libs/hidapi" | ||
| PATCHES=( | ||
| "${FILESDIR}"/${P}-cflags.patch |
There was a problem hiding this comment.
I think it's good, i have removed extra tab. Say me if it's bad. I use KDE with kate to edit my ebuild, i don't know what is the good tab size for gentoo ebuild
There was a problem hiding this comment.
I have removed old patch and add new patch with cflag and ldflag
Fulgurance
force-pushed
the
msi-keyboard
branch
from
bc01e57
to
1c26fab
Compare
Fulgurance
force-pushed
the
msi-keyboard
branch
2 times, most recently
from
d8e80b4
to
0f181c1
Compare
|
Did you test your ebuild? |
|
Yes I have tested. Yesterday, I wanted to correct my ebuild, but my body need to sleep 😂 |
Control backlight of MSI laptop keyboards Package-Manager: Portage 2.3.72, Repoman 2.3.17 Signed-off-by: Zohran Londais <zohran.londais@gmail.com>
Fulgurance
force-pushed
the
msi-keyboard
branch
from
0f181c1
to
2ceac5c
Compare
|
It's good ! Sorry for my bad patch |
Pull request CI reportReport generated at: 2019-08-20 09:00 UTC No issues found |
|
Thanks for your patience! Welcome aboard :) |
|
Thanks you very much !
Le mar. 20 août 2019 à 14:42, juippis <notifications@github.com> a écrit :
… Thanks for your patience! Welcome aboard :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11884?email_source=notifications&email_token=AHQZ2EZZUROHNOFJNONETDTQFPRCFA5CNFSM4HKU52U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WESSQ#issuecomment-522996042>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHQZ2EZMBHGHUW23SENJFXDQFPRCFANCNFSM4HKU52UQ>
.
|
Control backlight of MSI laptop keyboards
Package-Manager: Portage 2.3.66, Repoman 2.3.12
Signed-off-by: Zohran Londais zohran.londais@gmail.com