Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 #11915

Closed
wants to merge 2 commits into from
Closed

games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 #11915

wants to merge 2 commits into from

Conversation

nE0sIghT
Copy link
Contributor

@nE0sIghT nE0sIghT commented May 6, 2019

Closes: https://bugs.gentoo.org/685156

Signed-off-by: Yuri Konotopov ykonotopov@gnome.org

nE0sIghT added a commit to nE0sIghT/gentoo that referenced this pull request May 6, 2019
@nE0sIghT
games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2
38b6c02 
Closes: https://bugs.gentoo.org/685156
Closes: gentoo#11915

Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @nE0sIghT
Areas affected: ebuilds
Packages affected: games-emulation/pcsx2

games-emulation/pcsx2: @nE0sIghT, @gentoo/proxy-maint

Linked bugs

Bugs linked: 685156

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 6, 2019
nE0sIghT added a commit to nE0sIghT/gentoo that referenced this pull request May 6, 2019
@nE0sIghT
games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2
424f34f 
Closes: https://bugs.gentoo.org/685156
Closes: gentoo#11915

Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
a17r
a17r suggested changes May 6, 2019
View reviewed changes
games-emulation/pcsx2/pcsx2-9999.ebuild
@@ -42,9 +42,15 @@ DEPEND="${RDEPEND}

pkg_setup() {
if [[ ${MERGE_TYPE} != binary && $(tc-getCC) == *gcc* ]]; then
if [[ $(gcc-major-version) -lt 4 || $(gcc-major-version) == 4 && $(gcc-minor-version) -lt 8 ]] ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep changes limited to the topic of git summary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I splitted commits

Copy link
Member

@a17r a17r May 6, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a typo; I'd rather drop the whole check - all GCC versions up to 5.5.0 are masked at this point, thus not supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's typo - look one line up. There is no whitespace.
Since there is (masked) versions of gcc in portage I think this check is useful.
However if you insist I will drop this check - one space just doesn't worth time we spent on it.

nE0sIghT added a commit to nE0sIghT/gentoo that referenced this pull request May 6, 2019
@nE0sIghT
games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2
4f58c34 
Closes: https://bugs.gentoo.org/685156
Closes: gentoo#11915

Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
@nE0sIghT nE0sIghT changed the title games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 and fixed typo May 6, 2019
@nE0sIghT nE0sIghT changed the title games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 and fixed typo games-emulation/pcsx2: append -mxsave compiler flag with gcc >= 8.2 May 6, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-05-06 15:36 UTC
Newest commit scanned: a101a46
Status: ✅ good

No issues found

@gentoo-bot gentoo-bot closed this in d102ca1 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@nE0sIghT @gentoo-bot @gentoo-repo-qa-bot @a17r