Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-libs/grpc: Fix files installed outside prefix #11916

Closed
wants to merge 1 commit into from
Closed

net-libs/grpc: Fix files installed outside prefix #11916

wants to merge 1 commit into from

Conversation

indocomsoft
Copy link
Contributor

@indocomsoft indocomsoft commented May 6, 2019 •
edited

I was getting Aborting due to QA concerns: there are files installed outside the prefix when emerging net-libs/grpc.

This PR should fix this.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @indocomsoft
Areas affected: ebuilds
Packages affected: net-libs/grpc

net-libs/grpc: @perfinion, @gyakovlev

Linked bugs

Bugs linked: 685198

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 6, 2019
@gyakovlev gyakovlev self-requested a review May 6, 2019 19:02
@gyakovlev gyakovlev self-assigned this May 6, 2019
gyakovlev
gyakovlev suggested changes May 6, 2019
View reviewed changes
Copy link
Member

@gyakovlev gyakovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that.
Please edit all EAPI6 ebuild to be double-slash-less.

reference:
https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html#d-ed-root-eroot-no-longer-have-a-trailing-slash

net-libs/grpc/grpc-1.12.0.ebuild Outdated
@@ -59,7 +59,7 @@ src_compile() {

src_install() {
emake \
prefix="${D}"/usr \
prefix="${ED}"/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in EAPI6 ebuild this should be ${ED%/} ( or ${ED}"usr ) as this variable does not have a trailing slash in EAPI7 but does have it in EAPI6

net-libs/grpc/grpc-1.12.1-r1.ebuild Outdated
@@ -134,7 +134,7 @@ python_compile_all() {

src_install() {
emake \
prefix="${D}"/usr \
prefix="${ED}"/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

net-libs/grpc/grpc-1.13.0-r1.ebuild Outdated
@@ -138,7 +138,7 @@ python_compile_all() {

src_install() {
emake \
prefix="${D}"/usr \
prefix="${ED}"/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this as well

net-libs/grpc/grpc-1.13.1.ebuild Outdated
@@ -137,7 +137,7 @@ python_compile_all() {

src_install() {
emake \
prefix="${D}"/usr \
prefix="${ED}"/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and again

net-libs/grpc/grpc-1.15.0.ebuild Outdated
@@ -137,7 +137,7 @@ python_compile_all() {

src_install() {
emake \
prefix="${D}"/usr \
prefix="${ED}"/usr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the last one.

@indocomsoft
net-libs/grpc: Fix files installed outside prefix
75afb23 
Signed-off-by: Julius Putra Tanu Setiaji <indocomsoft@gmail.com>
Closes: https://bugs.gentoo.org/685198
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@indocomsoft
Copy link
Contributor Author

@gyakovlev Fixed!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-05-07 05:37 UTC
Newest commit scanned: 75afb23
Status: ✅ good

No issues found

pvdabeel pushed a commit to pvdabeel/gentoo that referenced this pull request May 7, 2019
@indocomsoft @gyakovlev
net-libs/grpc: Fix files installed outside prefix
3eb55c7 
Signed-off-by: Julius Putra Tanu Setiaji <indocomsoft@gmail.com>
Closes: https://bugs.gentoo.org/685198
Package-Manager: Portage-2.3.66, Repoman-2.3.12
Closes: gentoo#11916
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
@gyakovlev
Copy link
Member

EAPI7 ebuilds do not need stripping trailing slash, but I fixed it in my own commit right after yours.
thanks again, pushed.

@gyakovlev
Copy link
Member

closing manually, as CI bot is down.

3eb55c7

@gyakovlev gyakovlev closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyakovlev gyakovlev gyakovlev requested changes

Assignees

@gyakovlev gyakovlev

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@indocomsoft @gentoo-bot @gentoo-repo-qa-bot @gyakovlev