Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/audiotag: fix LICENSE, EAPI=7 bump #11976

Closed
wants to merge 2 commits into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented May 12, 2019

Hi,

This PR updates media-sound/audiotag for EAPI7 and fixes the LICENSE
Please review.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: media-sound/audiotag

media-sound/audiotag: @gentoo/sound

Linked bugs

Bugs linked: 685686


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 12, 2019
LICENSE="GPL-2+"
SLOT="0"
KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
IUSE="aac flac mp3 vorbis"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be moved to optfeature since they don't do anything in this ebuild?
(@gyakovlev)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, i've updated the ebuild to use optfeature instead.

Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@juippis
Copy link
Member

juippis commented Sep 23, 2019

has_version: Invalid atom: media-video/atomicparsley{-wez}
 * ERROR: media-sound/audiotag-0.19-r1::testworld failed (postinst phase):
 *   has_version: invalid atom: media-video/atomicparsley{-wez}
 *
 * Call stack:
 *          ebuild.sh, line 125:  Called pkg_postinst
 *        environment, line 548:  Called optfeature 'for m4a/mp4 support' 'media-video/atomicparsley{-wez}'
 *        environment, line 511:  Called has_version 'media-video/atomicparsley{-wez}'
 *   phase-helpers.sh, line 929:  Called ___best_version_and_has_version_common 'media-video/atomicparsley{-wez}'
 *   phase-helpers.sh, line 910:  Called die
 * The specific snippet of code:
 *                      die "${FUNCNAME[1]}: invalid atom: ${atom}"
 *
 * If you need support, post the output of `emerge --info '=media-sound/audiotag-0.19-r1::testworld'`,
 * the complete build log and the output of `emerge -pqv '=media-sound/audiotag-0.19-r1::testworld'`.
 * The complete build log is located at '/tmp/portage/media-sound/audiotag-0.19-r1/temp/build.log'.
 * The ebuild environment file is located at '/tmp/portage/media-sound/audiotag-0.19-r1/temp/environment'.
 * Working directory: '/tmp/portage/media-sound/audiotag-0.19-r1/homedir'
 * S: '/tmp/portage/media-sound/audiotag-0.19-r1/work/audiotag-0.19'
 * FAILED postinst: 1
>>> Regenerating /etc/ld.so.cache...

>>> Failed to execute postinst for media-sound/audiotag-0.19-r1

:(
FTR I thought it'd work too.

Closes: https://bugs.gentoo.org/685686
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@mm1ke
Copy link
Contributor Author

mm1ke commented Sep 24, 2019

@juippis

Nice catch.. Thx and fixed.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-24 17:16 UTC
Newest commit scanned: 7e18c05
Status: ✅ good

No issues found

@mm1ke mm1ke deleted the audi-9oRjEw4J branch October 28, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants