media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744) #11996

hjudt · 2019-05-14T11:30:52Z

New ebuild media-tv/tvbrowser-bin-4.0.1.ebuild: Themeable and easy to
use TV Guide - written in Java.

Signed-off-by: Harald Judt h.judt@gmx.at

gentoo-bot · 2019-05-14T11:32:13Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @hjudt
Areas affected: ebuilds
Packages affected: media-tv/tvbrowser-bin

media-tv/tvbrowser-bin: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

juippis · 2019-05-14T14:36:02Z

media-tv/tvbrowser-bin/metadata.xml

+<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
+<pkgmetadata>
+  <maintainer type="project">
+    <email>java@gentoo.org</email>


Have you asked if java team wants to maintain this? Add the proxy-maint project otherwise. Nevertheless, person should become before project.

juippis · 2019-05-14T14:36:29Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

@@ -0,0 +1,45 @@
+# Copyright 1999-2019 Gentoo Foundation


This copyright header is old, use repoman to commit so it fixes it for you automatically ;)

juippis · 2019-05-14T14:37:18Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+
+EAPI="7"
+
+inherit eutils desktop


I didn't see eutils being used in here, is it?

juippis · 2019-05-14T14:37:46Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+inherit eutils desktop
+
+DESCRIPTION="Themeable and easy to use TV Guide - written in Java"
+HOMEPAGE="http://www.tvbrowser.org"


Please use https:// since it's available.

juippis · 2019-05-14T14:38:45Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+KEYWORDS="~amd64 ~x86"
+
+RDEPEND="virtual/jdk:1.8"
+DEPEND="${RDEPEND}"


Doubt java is being used here during emerge, since it just seems to move pre-compiled files.

You can leave this empty or remove it.

juippis · 2019-05-14T14:40:22Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+src_install()
+{
+	# Copy files and directories
+	cd "${S}"


This should be the current working directory already.

juippis · 2019-05-14T14:49:46Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+	doins -r *
+
+	# Generate launcher
+	local tvbrowser_bin="tvbrowser"


In my opinion, what you're doing here is unneeded complexity, since it can be done a lot easier.

https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-apps/baselayout-java/baselayout-java-0.1.0-r1.ebuild#n29 This is a nice example how to.
(@gyakovlev)

This honestly does nothing, you can just use plain "tvbrowser" below instead of "${tvbrowser_bin}".

juippis · 2019-05-14T14:50:55Z

Bear in mind lately new package have had the least priority to be checked, so you might be better off trying to commit into GURU overlay meanwhile to work on your ebuild :)

hjudt · 2019-05-14T16:02:49Z

I have corrected the issues you mentioned.

juippis · 2019-05-14T19:08:02Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+SRC_URI="mirror://sourceforge/project/tvbrowser/TV-Browser%20Releases%20%28Java%208%20and%20higher%29/${PV}/${MY_PN}_${PV}_bin.tar.gz"
+LICENSE="GPL-3"
+SLOT="0"
+KEYWORDS="~amd64 ~x86"


One thing that came to my mind: Since it's a precompiled binary, does it work on amd64 and x86? Have you tested it on both arches? :)

I have not tested it on x86, but it is written in java and therefore should be platform-independent. At least it states to be on the homepage. It should probably work on other arches where the java runtime can run.

juippis · 2019-05-14T19:08:27Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+
+S="${WORKDIR}"/"${MY_P}"
+
+src_install()


Also please stick to ebuild.skel format, src_install() {

juippis · 2019-05-31T04:37:29Z

 * Messages for package media-tv/tvbrowser-bin-4.0.1:

 * QA Notice: broken .png files found:
 *    /var/tmp/portage/media-tv/tvbrowser-bin-4.0.1/image/opt/tvbrowser-bin-4.0.1/imgs/Filter16.png: broken IDAT window length

Otherwise emerges beautifully and seems to run really well.

juippis · 2019-05-31T04:39:39Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+	local tvbrowser_bin="tvbrowser"
+	exeinto /usr/bin
+	newexe - "${tvbrowser_bin}" <<-_EOF_
+#!/bin/sh


Remember indentation, and I believe bash is preferred with launchers / scripts like these. (I think sh is a symlink to system default shell interpreter, so go with bash)

Fixed indentation; I thought it would be necessary for the resulting file to have no indentation, but it luckily works without.
As for the png file, I don't think I'd have to do anything about it as a maintainer other than report it upstream.
I've also fixed the shell because we reference /bin/bash later anyway. I've looked it up in other ebuilds and they also use /bin/bash, and since portage depends on /bin/bash too it should be safe.

Also removed the tvbrowser_bin local variable.

mgorny · 2019-07-19T14:58:51Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+
+src_install() {
+	# Copy files and directories
+	dodir /opt/"${P}"


You don't need dodir if you're using doins. It creates directory automatically.

I've fixed this with the latest push.

mgorny · 2019-07-19T14:59:31Z

media-tv/tvbrowser-bin/tvbrowser-bin-4.0.1.ebuild

+	doins -r *
+
+	# Generate launcher
+	exeinto /usr/bin


Executables for stuff from /opt belong in /opt/bin.

Also the typical way of doing that would be:

into /opt dobin ...

Yes, but in this case the ebuild is generating the launcher, thus using exeinto and not dobin. However, I've adapted the path to /opt/bin now.

New ebuild media-tv/tvbrowser-bin-4.0.1.ebuild: Themeable and easy to use TV Guide - written in Java. Signed-off-by: Harald Judt <h.judt@gmx.at>

gentoo-repo-qa-bot · 2019-07-19T18:02:40Z

Pull request CI report

Report generated at: 2019-07-19 18:02 UTC
Newest commit scanned: 60dcd31
Status: ✅ good

All QA issues have been fixed!

juippis · 2019-08-01T12:23:56Z

I cleaned the ebuild a bit. Please take this into upstream

 * QA Notice: broken .png files found:
 *    /tmp/portage/media-tv/tvbrowser-bin-4.0.1/image/opt/tvbrowser-bin-4.0.1/imgs/Filter16.png: broken IDAT window length

and try to get it resolved before next version is released.

gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 14, 2019

juippis reviewed May 14, 2019

View reviewed changes

hjudt added a commit to hjudt/gentoo that referenced this pull request May 14, 2019

media-tv/tvbrowser-bin: Fix issues in PR gentoo#11996

3ba6f73

juippis reviewed May 14, 2019

View reviewed changes

hjudt force-pushed the tvbrowser-bin branch from 788fb88 to 57574f6 Compare May 15, 2019 10:57

juippis reviewed May 31, 2019

View reviewed changes

hjudt force-pushed the tvbrowser-bin branch from 57574f6 to ed5aadc Compare May 31, 2019 11:00

mgorny requested changes Jul 19, 2019

View reviewed changes

media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744)

60dcd31

New ebuild media-tv/tvbrowser-bin-4.0.1.ebuild: Themeable and easy to use TV Guide - written in Java. Signed-off-by: Harald Judt <h.judt@gmx.at>

hjudt force-pushed the tvbrowser-bin branch from ed5aadc to 60dcd31 Compare July 19, 2019 17:35

gentoo-bot closed this in 82b6355 Aug 1, 2019

hjudt deleted the tvbrowser-bin branch June 2, 2020 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744) #11996

media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744) #11996

hjudt commented May 14, 2019

gentoo-bot commented May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 14, 2019

juippis May 31, 2019

juippis commented May 14, 2019

hjudt commented May 14, 2019 •

edited

juippis May 14, 2019

hjudt May 15, 2019

juippis May 14, 2019

juippis commented May 31, 2019

juippis May 31, 2019

hjudt May 31, 2019

hjudt May 31, 2019

mgorny Jul 19, 2019

hjudt Jul 19, 2019

mgorny Jul 19, 2019

hjudt Jul 19, 2019

gentoo-repo-qa-bot commented Jul 19, 2019

juippis commented Aug 1, 2019


		EAPI="7"

		inherit eutils desktop


		S="${WORKDIR}"/"${MY_P}"

		src_install()

media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744) #11996

media-tv/tvbrowser-bin: Themeable and easy to use TV Guide (bug #685744) #11996

Conversation

hjudt commented May 14, 2019

gentoo-bot commented May 14, 2019

Copyright policy change

Pull Request assignment

Linked bugs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juippis commented May 14, 2019

hjudt commented May 14, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juippis commented May 31, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jul 19, 2019

Pull request CI report

juippis commented Aug 1, 2019

hjudt commented May 14, 2019 •

edited