Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-misc/goobook: Bump to 3.3 #12061

Closed
wants to merge 1 commit into from
Closed

app-misc/goobook: Bump to 3.3 #12061

wants to merge 1 commit into from

Conversation

thinrope
Copy link
Contributor

@thinrope thinrope commented May 20, 2019 •
edited

  • support for python-3.{6,7}
  • removed indirect dependencies
  • EAPI=7
  • fixed syntax per PR conversation
  • added /self as proxy maintainer

Bug: https://bugs.gentoo.org/686384
Reported-by: Kalin KOZHUHAROV kalin@thinrope.net
Signed-off-by: Kalin KOZHUHAROV kalin@thinrope.net
Related: https://bugs.gentoo.org/678398

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @thinrope
Areas affected: ebuilds
Packages affected: app-misc/goobook

app-misc/goobook: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 686384

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 20, 2019
@thinrope
Copy link
Contributor Author

When this lands properly, we can remove the older version and close its QA bug https://bugs.gentoo.org/670536

titanofold
titanofold suggested changes May 20, 2019
View reviewed changes
Copy link
Member

@titanofold titanofold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

The comment should be edited, too. This isn't a revision bump, but just a standard bump. So, the first line should read: "app-misc/goobook: Bump to 3.3".

Additionally, "Merged from thinrope/pkalin@467e3a2" is meaningless in the Gentoo repo context, so should be removed.

app-misc/goobook/goobook-3.3.ebuild Outdated Show resolved Hide resolved
app-misc/goobook/goobook-3.3.ebuild Show resolved Hide resolved
app-misc/goobook/goobook-3.3.ebuild Outdated Show resolved Hide resolved
app-misc/goobook/goobook-3.3.ebuild Outdated Show resolved Hide resolved
@thinrope thinrope changed the title app-misc/goobook: revbump to app-misc/goobook-3.3 app-misc/goobook-3.3: version bump May 20, 2019
@titanofold
Copy link
Member

The first line of the commit message should be written: "app-misc/goobook: Bump to 3.3".

@titanofold
Copy link
Member

Also, if you would like to assume maintainership, add yourself and Proxy to the metadata.xml.

https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml

@thinrope
app-misc/goobook: Bump to 3.3
618e6a5 
* support for python-3.{6,7}
* removed indirect dependencies
* EAPI=7
* fixed syntax per PR conversation
* added /self as proxy maintainer

Bug: https://bugs.gentoo.org/686384
Reported-by: Kalin KOZHUHAROV <kalin@thinrope.net>
Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
Related: https://bugs.gentoo.org/678398
@thinrope thinrope changed the title app-misc/goobook-3.3: version bump app-misc/goobook: Bump to 3.3 May 20, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-05-20 20:54 UTC
Newest commit scanned: 618e6a5
Status: ✅ good

No issues found

thinrope pushed a commit to thinrope/pkalin that referenced this pull request May 22, 2019
app-misc/goobook: merged upstream, removing
d659380 
branch: https://github.com/thinrope/gentoo/tree/BGO686384
PR:	gentoo/gentoo#12061
commit:	gentoo/gentoo@377b0ff
@thinrope thinrope deleted the BGO686384 branch May 22, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanofold titanofold titanofold approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@thinrope @gentoo-bot @titanofold @gentoo-repo-qa-bot