Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicad 5.1.2 #12088

Closed
wants to merge 8 commits into from
Closed

Kicad 5.1.2 #12088

wants to merge 8 commits into from

Conversation

zpuskas
Copy link
Contributor

@zpuskas zpuskas commented May 23, 2019

No description provided.

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @zpuskas
Areas affected: ebuilds
Packages affected: app-doc/kicad-doc, sci-electronics/kicad, sci-electronics/kicad-footprints, sci-electronics/kicad-i18n, sci-electronics/kicad-meta...

app-doc/kicad-doc: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-footprints: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-i18n: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-meta: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-packages3d: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-symbols: @zpuskas, @gentoo/proxy-maint
sci-electronics/kicad-templates: @zpuskas, @gentoo/proxy-maint

Linked bugs

Bugs linked: 682876, 686062

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 23, 2019
@ghost
Copy link

ghost commented Jun 1, 2019

Builds and runs fine for me. I have two questions:

  1. Any particular reason why you left out python 3.5 compat? I understand why 3.7 isn't there (boost < 1.70 doesn't have it and 1.70 is masked), but I don't understand 3.5.

  2. I don't understand why the CI doesn't cry about this: wxpython:4.0 isn't keyworded for arm64. repoman -dx full complains about this on my machine. Doesn't it complains on yours too? You will have to drop the ~arm64 keyword and open a re-keywording request.

@zpuskas
Copy link
Contributor Author

zpuskas commented Jun 3, 2019

@hsoft Good points.

1, I left out Python 3.5, because I thought there was a dependency not supporting it. However having gone through them now quickly this does not seem to be the case. I might have confused this with something. Will double check and reenable 3.5 tonight.

2, I think it complained for the 17.1 dev profile only as a warning, not an error. However I would argue that here the better solution would be either make wxpython-4 work with arm64 or maybe reverting to previous wxpython that works on arm64 too? Should we not move toward arm64 support?

Though I don't know how many people use KiCAD on arm64, maybe we can just drop it completely, since on arm64 we already have some use mask for it:

/usr/portage/profiles $ rg kicad
...
arch/arm64/package.use.mask
77:sci-electronics/kicad occ oce ngspice

@ghost
Copy link

ghost commented Jun 3, 2019

Dropping arches when new dependencies aren't keyworded for them is fine, it's part of the regular process. It's just that whenever we drop them, we open re-keywording bugs so that the arch teams can keyword new dependencies and re-keyword kicad.

It's just that arm64 arches typically take a long time to process these bug, to re-keywording takes a while...

So to answer your question 2: sure, if you want, you can stay with wxpython 3.x (and python 2, and gtk 2) until wxpython is keyworded for arm64, but that could take a long while. Personally, I'd rather go for dropping arm64 and move forward.

@zpuskas
sci-electronics/kicad: Bump to 5.1.2
91623b8 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-symbols: Bump to 5.1.2
6f414de 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-footprints: Bump to 5.1.2
b110bc9 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-templates: Bump to 5.1.2
1881540 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-packages3d: Bump to 5.1.2
9658110 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-i18n: bump to 5.1.2
26e320f 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
app-doc/kicad-doc: Bump to 5.1.2
325c12b 
Bug: https://bugs.gentoo.org/686062
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
sci-electronics/kicad-meta: Bump to 5.1.2
9f5e557 
Closes: https://bugs.gentoo.org/686062
Closes: https://bugs.gentoo.org/682876
Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Package-Manager: Portage-2.3.66, Repoman-2.3.12
@zpuskas
Copy link
Contributor Author

zpuskas commented Jun 4, 2019

Added Python 3.5, double checked deps and ran repoman -dx full too. No warnings.

I've decided to drop ~arm64 as half of the KiCAD ebuild have not been even keyworded for that. There is no point in providing a broken experience.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-06-04 05:11 UTC
Newest commit scanned: 9f5e557
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/1f7d78d/output.html#media-gfx/openexr_viewers

@gentoo-bot gentoo-bot closed this in 21a1bbd Jun 4, 2019
@NeddySeagoon
Copy link
Contributor

kicad-5.1.0 seems OK on an ~arm64 Raspberry Pi and an ~arm64 Acer R13 Chromebook.
It would be a shame to drop the ~arm64 keyword as proposed in bug 687322.

I'll do the work to keyword the dependencies on ~arm64. If new keywords are required for this PR to go ahead, drop ~arm64 now and I'll add it back later. It will be a week or two until I get to this.

@zpuskas zpuskas deleted the kicad-5.1.2 branch June 23, 2019 01:16
@zpuskas zpuskas restored the kicad-5.1.2 branch June 23, 2019 01:16
@zpuskas zpuskas deleted the kicad-5.1.2 branch June 23, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@zpuskas @gentoo-bot @gentoo-repo-qa-bot @NeddySeagoon