Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson.eclass: fix cross compile file for mingw #12168

Closed
wants to merge 1 commit into from

Conversation

g-braeunlich
Copy link
Contributor

This is necessary for cross compiling for example x11-libs/gdk-pixbuf

An other solution would be to include
windres = $(_meson_env_array "$(tc-getRC)")
regardless ot the target.

@floppym and or William Hubbs: Can you take a look at this?

Signed-off-by: Gerhard Bräunlich g.braeunlich@disroot.org

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @g-braeunlich
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added the need assignment It was impossible to assign the PR correctly. Please assign it manually. label Jun 2, 2019
@floppym
Copy link
Contributor

floppym commented Jun 2, 2019

I think I prefer to set windres unconditionally, assuming that won't break other targets. Let's give that a try.

This is necessary for cross compiling for example x11-libs/gdk-pixbuf

Signed-off-by: Gerhard Bräunlich <g.braeunlich@disroot.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-06-02 14:30 UTC
Newest commit scanned: 50e6638
Status: ✅ good

No issues found

@g-braeunlich
Copy link
Contributor Author

I think I prefer to set windres unconditionally, assuming that won't break other targets. Let's give that a try.

OK. Modified the commit

@gentoo-bot gentoo-bot closed this in ca383d8 Jun 3, 2019
@g-braeunlich g-braeunlich deleted the meson-migw-fix branch June 4, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
4 participants