Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-video/aegisub: Enable testing with >=dev-cpp/gtest-1.8.1 #12230

Closed
wants to merge 1 commit into from
Closed

media-video/aegisub: Enable testing with >=dev-cpp/gtest-1.8.1 #12230

wants to merge 1 commit into from

Conversation

Peter-Levine
Copy link
Contributor

I maintain dev-cpp/gtest . This is the last package to depend on dev-cpp/gtest-1.7.0 and I would love to eventually purge it from the tree. Tests build, run, and pass just fine with >=dev-cpp/gtest-1.8.1 though a few unrelated lua tests sporadically fail, likely due to Aegisub/Aegisub#99.

Note, the patch was modified to pass $(CFLAGS_PTHREAD) as a value for GTEST_CXXFLAGS. The value of $(shell pkg-config --cflags gtest) or $(shell pkg-config --cflags-only-other gtest) would have included -lpthread while compiling a pre-compiled header. This, for some reason, triggers gcc into building it as an executable and the build fails since it can't find main().

Tested with dev-cpp/gtest-1.8.1-r2 and dev-cpp/gtest-1.9.0_pre20190607

Package-Manager: Portage-2.3.67, Repoman-2.3.13
Signed-off-by: Peter Levine plevine457@gmail.com

@Peter-Levine
media-video/aegisub: Enable testing with >=dev-cpp/gtest-1.8.1
7e6600e 
Updates the gtest dependency. Tests build, run, and pass without issue.

Package-Manager: Portage-2.3.67, Repoman-2.3.13
Signed-off-by: Peter Levine <plevine457@gmail.com>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @Peter-Levine
Areas affected: ebuilds
Packages affected: media-video/aegisub

media-video/aegisub: @sarnex

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 9, 2019
@gentoo-bot gentoo-bot closed this in 9e3ec79 Jun 9, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-06-09 19:50 UTC
Newest commit scanned: 7e6600e
Status: ✅ good

No issues found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
3 participants
@Peter-Levine @gentoo-bot @gentoo-repo-qa-bot