media-libs/mesa: introduce X flag / enable wayland-only systems #12333
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @trilean @gentoo/github: Too many disjoint maintainers, disabling auto-assignment. Linked bugsBugs linked: 560096 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
|
One pull request per package, or at least one pull request per group of packages with the same maintainer, would have been better. |
|
Why the default |
https://bugs.gentoo.org/560096#c22:
What do we do about the QA issues? They're not related to my PR but existing issues in the tree. |
|
On Thu, 2019-06-27 at 00:55 -0700, Philipp Ammann wrote:
> What do we do about the QA issues? They're not related to my PR but existing issues in the tree.
They are fixed now, so please rebase.
|
Rebase and force-push over the existing PR? I'll do that in the evening (UTC+2). |
trilean
force-pushed
the
mesa-optional-x11
branch
3 times, most recently
from
7bffc7b
to
2f0e0ae
Compare
|
I've rebased the PR again, fixing a new conflict. |
trilean
force-pushed
the
mesa-optional-x11
branch
from
2f0e0ae
to
4333375
Compare
|
And another rebase...can we move this forward? |
|
Sorry, I don't know how this fell off my radar. I've committed the first two patches (and modified the second to only modify mesa-9999 since there's so much potential for breakage). I'm concerned about the 3rd patch. I see lots of packages left that look like they should be modified. media-libs/waffle for instance has a USE=X flag. Don't you think it should depend on mesa[X(+)?]? |
|
My reasoning was that it's better to make everything that depends on mesa now require the X flag and sort out those that don't later. That way we don't cause any breakage because there's no change from the status quo. IMO users will try to build wayland-only systems and will report packages that needlessly depend on In case of |
trilean
force-pushed
the
mesa-optional-x11
branch
from
4333375
to
287226d
Compare
Bug: https://bugs.gentoo.org/560096 Package-Manager: Portage-2.3.67, Repoman-2.3.16 Signed-off-by: Philipp Ammann <philipp.ammann@posteo.de>
This changes any package that depends on media-libs/mesa (though not virtual/opengl) to depend on media-libs/mesa[X(+)] instead. Bug: https://bugs.gentoo.org/560096 Package-Manager: Portage-2.3.67, Repoman-2.3.16 Signed-off-by: Philipp Ammann <philipp.ammann@posteo.de>
Pull request CI reportReport generated at: 2019-07-29 17:44 UTC Issues already there before the PR (double-check them): |
|
Is there a reason not to take the "depends" patch? |
|
Thanks, merged (after some updates) as commit 97c3d2d. |
|
New ebuilds missed by that commit: |
See https://bugs.gentoo.org/560096. This is a continuation of #4374.
This PR introduces an X use-flag for Mesa. This makes it possible to build Mesa without GLX and therefore without XLib & friends. To make existing packages not break I've
seded the entire tree and replaced most dependencies onmedia-libs/mesawithmedia-libs/mesa[X(+)]. Exceptions are:Obvious
DONE
TODO
COMMON_DEPEND="media-libs/mesa[X(+)]"as stop-gap)if use opengl || use gles2insrc_configure)