dev-lang/jimtcl-0.78-r2: Clean up #12396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-bot
added
maintainer-needed
eugene-bright
changed the title
eugene-bright
changed the title
gentoo-bot
changed the title
gentoo-bot
added
maintainer-needed
eugene-bright
changed the title
eugene-bright
changed the title
mgorny
requested changes
Jul 7, 2019
| @@ -49,5 +49,5 @@ src_install() { | |||
| doins jim.h jimautoconf.h jim-subcmd.h jim-signal.h \ | |||
| jim-win32compat.h jim-eventloop.h jim-config.h | |||
| dodoc AUTHORS README TODO | |||
| use doc && dohtml Tcl.html | |||
| use doc && (docinto html; dodoc Tcl.html) | |||
There was a problem hiding this comment.
Don't use a subshell. Use if; then.
eugene-bright
force-pushed
the
jimtcl
branch
3 times, most recently
from
f66620e
to
2511501
Compare
|
@mgorny, thank you for proxying my commits. |
|
Well, I suppose the result is reproducible now… but not sure if really expected: |
|
|
|
It's exactly that happens in https://bugs.gentoo.org/675276 |
|
I can provide dirty workaround: disable bootstrapping and always use |
|
I'd like to see coredump stacktrace if possible. Can't reproduce segfault by myself. |
|
Ok, give me a few minutes. |
mgorny
reviewed
Jul 7, 2019
|
gentoo-bot
added
maintainer-needed
eugene-bright
changed the title
gentoo-bot
changed the title
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @eugene-bright dev-lang/jimtcl: @gentoo/proxy-maint (maintainer needed) Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
|
@mgorny, could you try to emerge it in your environment one more time? Patches were added. |
mgorny
reviewed
Jul 7, 2019
| @@ -7,7 +7,7 @@ d=`dirname "$0"` | ||
| PATH="$PATH:$d"; export PATH | ||
| echo 1>&2 "Bootstrap jimsh0" | ||
| for cc in ${CC_FOR_BUILD:-cc} gcc; do |
There was a problem hiding this comment.
While at it, replace cc with ${CC:-cc}.
| echo 1>&2 "Bootstrap jimsh0" | ||
| for cc in ${CC_FOR_BUILD:-cc} gcc; do | ||
| - { $cc -o "$d/jimsh0" "$d/jimsh0.c"; } 2>/dev/null || continue | ||
| + { $cc -o "$d/jimsh0" "$d/jimsh0.c" $CFLAGS; } 2>/dev/null || continue |
There was a problem hiding this comment.
Also LDFLAGS and CPPFLAGS, please, and preferably in standard make order.
There was a problem hiding this comment.
Should we really pass CPPFLAGS to C compiler? Could it contain incompatible options?
There was a problem hiding this comment.
Yes, these are preprocessor flags.
| @@ -0,0 +1,13 @@ | |||
| diff --git a/autosetup/autosetup-find-tclsh b/autosetup/autosetup-find-tclsh | |||
There was a problem hiding this comment.
Could you please merge it with the previous patch? It's a bit fragile to apply two separate patches to the same file, and both are Gentoo-specific.
| @@ -0,0 +1,16 @@ | |||
| diff --git a/autosetup/jimsh0.c b/autosetup/jimsh0.c | |||
There was a problem hiding this comment.
I'm afraid this doesn't help at all.
There was a problem hiding this comment.
Looks like I've just deleted MINGW specific implementation.
I will look for workaround if no obvious solution is found.
There was a problem hiding this comment.
Hmm, FWICS upstream is still alive and kicking, so maybe try adding a new version (or a git snapshot if upstream doesn't release).
There was a problem hiding this comment.
Good idea. I will look for changes on a week. May be I'll find something.
If someone here needs a fast workaround then let me know. We can just bypassing bootstrapping by forcing tclsh usage.
Pull request CI reportReport generated at: 2019-07-07 19:30 UTC No issues found |
Make `autosetup/autosetup-find-tclsh` scripts use system `tclsh`. Forbid building `jimsh0`. Closes: https://bugs.gentoo.org/675276 Signed-off-by: Eugene Bright <eugene@bright.gdn>
dohtml is replaces with docinto+dodoc. Closes: https://bugs.gentoo.org/689378 Signed-off-by: Eugene Bright <eugene@bright.gdn>
|
@mgorny please try to rebuild it again. I've disabled bootstrapping to workaround econf failed. It's a dirty solution that adds |
|
Thanks. Repoman says: I'll fix that for you and merge it. |
mgorny
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comply with EAPI=7.
Revive bootstrap forcing patch.
Closes: https://bugs.gentoo.org/689378
Closes: https://bugs.gentoo.org/675276
Signed-off-by: Eugene Bright eugene@bright.gdn