New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-p2p/deluge: version bump to 2.0.3 #12548
Conversation
Closes: https://bugs.gentoo.org/688024 Signed-off-by: Paolo Pedroni <paolo.pedroni@iol.it> Package-Manager: Portage-2.3.66, Repoman-2.3.16
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @PPed72 net-p2p/deluge: @PPed72, @krifisk, @gentoo/proxy-maint Linked bugsBugs linked: 688024 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2019-07-26 14:42 UTC No issues found |
webinterface? ( dev-python/mako[${PYTHON_USEDEP}] )" | ||
|
||
python_prepare_all() { | ||
local args=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace those sed
s with a patch. This is horribly unreadable.
distutils-r1_python_prepare_all | ||
} | ||
|
||
esetup.py() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding eclass functions is not acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I understand.
Do you have any suggestion on how to achieve the same result. I have no idea what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try overriding whatever you need to override via setup.cfg.
|
||
python_install_all() { | ||
distutils-r1_python_install_all | ||
python_export PYTHON_SITEDIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declare it as local variable.
} | ||
|
||
pkg_postinst() { | ||
enewgroup ${PN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to replace this with GLEP 81-compliant packages, with RFC and all.
IUSE="console geoip gtk libnotify sound webinterface" | ||
REQUIRED_USE=" | ||
${PYTHON_REQUIRED_USE} | ||
sound? ( gtk ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort, please.
dev-python/chardet[${PYTHON_USEDEP}] | ||
dev-python/dbus-python[${PYTHON_USEDEP}] | ||
dev-python/distro[${PYTHON_USEDEP}] | ||
dev-python/rencode[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort.
|
||
PYTHON_COMPAT=( python3_{5,6} ) | ||
DISTUTILS_SINGLE_IMPL=1 | ||
inherit distutils-r1 eutils systemd user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you're using eutils.
Closes: https://bugs.gentoo.org/688024 Closes: gentoo#12548 Closes: gentoo#9327 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Craig Andrews <candrews@gentoo.org>
Closes: https://bugs.gentoo.org/688024 Closes: gentoo#12548 Closes: gentoo#9327 Closes: gentoo#13243 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Craig Andrews <candrews@gentoo.org>
Closes: https://bugs.gentoo.org/688024
Signed-off-by: Paolo Pedroni paolo.pedroni@iol.it
Package-Manager: Portage-2.3.66, Repoman-2.3.16