Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-p2p/deluge: version bump to 2.0.3 #12548

Closed
wants to merge 1 commit into from

Conversation

PPed72
Copy link
Contributor

@PPed72 PPed72 commented Jul 26, 2019

Closes: https://bugs.gentoo.org/688024
Signed-off-by: Paolo Pedroni paolo.pedroni@iol.it
Package-Manager: Portage-2.3.66, Repoman-2.3.16

Closes: https://bugs.gentoo.org/688024
Signed-off-by: Paolo Pedroni <paolo.pedroni@iol.it>
Package-Manager: Portage-2.3.66, Repoman-2.3.16
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @PPed72
Areas affected: ebuilds
Packages affected: net-p2p/deluge

net-p2p/deluge: @PPed72, @krifisk, @gentoo/proxy-maint

Linked bugs

Bugs linked: 688024


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 26, 2019
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-07-26 14:42 UTC
Newest commit scanned: 9de1c24
Status: ✅ good

No issues found

webinterface? ( dev-python/mako[${PYTHON_USEDEP}] )"

python_prepare_all() {
local args=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace those seds with a patch. This is horribly unreadable.

distutils-r1_python_prepare_all
}

esetup.py() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding eclass functions is not acceptable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I understand.
Do you have any suggestion on how to achieve the same result. I have no idea what to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try overriding whatever you need to override via setup.cfg.


python_install_all() {
distutils-r1_python_install_all
python_export PYTHON_SITEDIR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare it as local variable.

}

pkg_postinst() {
enewgroup ${PN}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace this with GLEP 81-compliant packages, with RFC and all.

IUSE="console geoip gtk libnotify sound webinterface"
REQUIRED_USE="
${PYTHON_REQUIRED_USE}
sound? ( gtk )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort, please.

dev-python/chardet[${PYTHON_USEDEP}]
dev-python/dbus-python[${PYTHON_USEDEP}]
dev-python/distro[${PYTHON_USEDEP}]
dev-python/rencode[${PYTHON_USEDEP}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort.


PYTHON_COMPAT=( python3_{5,6} )
DISTUTILS_SINGLE_IMPL=1
inherit distutils-r1 eutils systemd user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you're using eutils.

candrews added a commit to candrews/gentoo that referenced this pull request Oct 9, 2019
Closes: https://bugs.gentoo.org/688024
Closes: gentoo#12548
Closes: gentoo#9327
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Craig Andrews <candrews@gentoo.org>
candrews added a commit to candrews/gentoo that referenced this pull request Oct 9, 2019
Closes: https://bugs.gentoo.org/688024
Closes: gentoo#12548
Closes: gentoo#9327
Closes: gentoo#13243
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Craig Andrews <candrews@gentoo.org>
@PPed72 PPed72 deleted the deluge-2.0.3 branch October 16, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants