Bump media-sound/beets to 1.4.9 #12582
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @lovesegfault media-sound/beets: @gentoo/sound Linked bugsBugs linked: 689182 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
Rebased |
| dev-python/setuptools[${PYTHON_USEDEP}] | ||
| " | ||
|
|
||
| RESTRICT="test" # tests broken in 1.4.3 already |
There was a problem hiding this comment.
Have they been fixed for 1.4.9 though? ;)
There was a problem hiding this comment.
Yes, but they require a large refactoring of the ebuild which will come in a revbump after I merge some more packages.
media-sound/beets/beets-1.4.9.ebuild
Outdated
| done | ||
|
|
||
| if ! use mpd; then | ||
| rm -f test/test_player.py || die |
There was a problem hiding this comment.
Ǹo -f please, i makes it so rm never dies. I'm not a huge fan of this style of removing plugins, since switching a USE flag requires re-compiling this again, while if you just left everything in place, would the functionality be available after installing said package?
Well since this looks like a small package I don't mind so much about recompiling it.
There was a problem hiding this comment.
I completely agree with you, I am working towards a complete rewrite of this ebuild that removes this completely. I'll be submitting new pkg requests in the next couple of days. For now I'm leaving it untouched in favour of a simpler bump.
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: Bernardo Meurer <bernardo@standard.ai>
Closes: https://bugs.gentoo.org/689182 Package-Manager: Portage-2.3.69, Repoman-2.3.16 Signed-off-by: Bernardo Meurer <bernardo@standard.ai>
|
@juippis Pushed the changes. This is an admittedly poor bump, but to make this ebuild good will take a lot of work, I'm 60% of the way there. We can either:
I've been running 1.4.9 off of this ebuild for almost a month now with no problems, FWIW. |
Pull request CI reportReport generated at: 2019-08-30 06:02 UTC Issues already there before the PR (double-check them): |
| discogs? ( dev-python/discogs-client[${PYTHON_USEDEP}] ) | ||
| ffmpeg? ( media-video/ffmpeg:0[encode] ) | ||
| gstreamer? ( | ||
| media-libs/gst-plugins-good:1.0 |
There was a problem hiding this comment.
Remember to sort this properly on the revbump.
| media-libs/gst-plugins-good:1.0 | ||
| media-libs/gst-plugins-bad:1.0 | ||
| ) | ||
| icu? ( dev-db/sqlite[icu] ) |
There was a problem hiding this comment.
This is slotted if I recall correctly.
No description provided.