media-gfx/cura-4.2.1: version bump #12618
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @Perlovka dev-libs/libarcus: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka Linked bugsBugs linked: 691144, 687324, 680988, 691398 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
|
@Amynka FYI, PR is already here 😉 (#9199 (comment)) |
could you look into this? |
|
Seems like I can't even build curaengine, any ideas? |
|
@juippis are you using gcc-9? https://bugs.gentoo.org/685178 |
|
I can confirm everything builds for me with gcc-8.3.0. Sadly some functionality is still broken running as a regular user as described here Ultimaker/Cura#5488 |
|
Yes. You then have to fix the "broken" ebuild to depend on a working gcc, and make a check that such version of gcc is being used when trying to compile that package. |
|
Upstream apparently still is discussing the best way to tackle this, I think depending on gcc-8 is the best solution for now. @Perlovka can you update the PR? |
|
@MathyV <=gcc-8 for all ebuilds? gcc-9 is masked on my machines, can't check right now. |
|
Remember that you need to use either |
|
I don't have gcc-9 either so I can't check but in general, would anyone use
two compilers to build the application and dependencies?
…On Wed, Aug 21, 2019, 06:54 juippis ***@***.***> wrote:
Remember that you need to use either gcc-*version checks from
toolchain-funcs.eclass or has_version to make it work. There are multiple
examples in the tree.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12618?email_source=notifications&email_token=ABQY6A4S6UV3N7NY6ZNP7UDQFTDABA5CNFSM4IJFWKG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YNTSI#issuecomment-523295177>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQY6AYZPU5ZGWK4HCSFE33QFTDABANCNFSM4IJFWKGQ>
.
|
Well, I have no idea why src_test() is in ebuild, probably from ancient version. |
Perlovka
force-pushed
the
media-gfx/cura
branch
from
b103e64
to
4b5b705
Compare
|
Seems like only curaengine can't be built with gcc-9 or clang-8 (Ultimaker/CuraEngine#984 (comment)), so added checks for clang as well. Fixed BDEPENDs where applicable. |
Perlovka
force-pushed
the
media-gfx/cura
branch
from
4b5b705
to
01c5732
Compare
Package-Manager: Portage-2.3.70, Repoman-2.3.16 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Closes: https://bugs.gentoo.org/691398 Package-Manager: Portage-2.3.70, Repoman-2.3.16 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Package-Manager: Portage-2.3.70, Repoman-2.3.16 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Package-Manager: Portage-2.3.70, Repoman-2.3.16 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Closes: https://bugs.gentoo.org/680988 Closes: https://bugs.gentoo.org/687324 Closes: https://bugs.gentoo.org/691144 Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Michael Perlov <perlovka@gmail.com>
Perlovka
force-pushed
the
media-gfx/cura
branch
from
01c5732
to
b886bc7
Compare
Pull request CI reportReport generated at: 2019-08-21 23:01 UTC Issues already there before the PR (double-check them): |
|
3 packages failed to compile with FEATURES="test" USE="test". I expect you to fix or RESTRICT them. Then there's this: I'll open bug reports for these errors later when I have more time, but for now, let's get this merged. Thanks! |
Closes: https://bugs.gentoo.org/680988 Closes: https://bugs.gentoo.org/687324 Closes: https://bugs.gentoo.org/691144 Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Michael Perlov <perlovka@gmail.com> Closes: gentoo#12618 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Cura 4.2.1 and dependencies version bump