Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/pigpio: fix libdir variable #12677

Closed
wants to merge 2 commits into from
Closed

Conversation

github-k8n
Copy link
Contributor

Fixed libdir variable (/usr/ prefix missing, current ebuilds do not install libs at all)

Signed-off-by: Daniel Kenzelmann gentoo@k8n.de

Fixed libdir variable (/usr/ prefix missing, current ebuilds do not install libs at all)

Signed-off-by: Daniel Kenzelmann <gentoo@k8n.de>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @github-k8n
Areas affected: ebuilds
Packages affected: dev-libs/pigpio

dev-libs/pigpio: @github-k8n, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Aug 11, 2019
@github-k8n
Copy link
Contributor Author

Ah, crap, wanted to make two separate cases here, but somehow it did join the pull requests here .. still not that good with git :-(

Hope that still works, the updated old ebuilds and the new ebuild are separate commits here..

New ebuild, now with .so versioning from upstream, new Makefile patch required

Signed-off-by: Daniel Kenzelmann <gentoo@k8n.de>
@github-k8n
Copy link
Contributor Author

Forgot to update Manifest file with second commit, included/rebased it with new ebuild commit ...

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-08-11 13:41 UTC
Newest commit scanned: 201ab91
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/aae140a/output.html#sci-chemistry/gelemental

@github-k8n
Copy link
Contributor Author

There was a new bug after I submitted the pull request pointing out the libdir issue https://bugs.gentoo.org/691948

@juippis
Copy link
Member

juippis commented Aug 13, 2019

Can't test this (yet) but overall looks good. Thanks!

@github-k8n
Copy link
Contributor Author

hmm.. isn't it supposed to include both commits? I only see "dev-libs/pigpio-70: new ebuild" (201ab91) merged, but not "dev-libs/pigpio: fix libdir variable" (05740e2)

@juippis
Copy link
Member

juippis commented Aug 13, 2019

It's there, as a separate commit:
c85f15d
7ab8f55

PS your dev-libs/pigpio-70 is wrongly formatted, I apparently failed to rebase it to its right form while closing the bug you linked, but keep that in mind for the next time :) write something like dev-libs/pigpio: bump to version 70.

@github-k8n
Copy link
Contributor Author

thanks, will do :)

@github-k8n github-k8n deleted the pigpio branch August 17, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants