Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-misc/solaar: Version bump to 1.0.1, Python 3.7 and EAPI 7 #12679

Closed
wants to merge 1 commit into from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Aug 11, 2019

Bug: https://bugs.gentoo.org/691208
Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Chris Mayo aklhfex@gmail.com


Update web addresses and swap gnome2-utils for xdg.

--- solaar-0.9.2-r3.ebuild
+++ solaar-1.0.1.ebuild
@@ -1,18 +1,18 @@
 # Copyright 1999-2019 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=5
-PYTHON_COMPAT=( python{2_7,3_5,3_6} )
+EAPI=7
+PYTHON_COMPAT=( python2_7 python3_{5,6,7} )
 
-inherit distutils-r1 udev user linux-info gnome2-utils
+inherit distutils-r1 linux-info udev user xdg
 
 DESCRIPTION="A Linux device manager for Logitech's Unifying Receiver peripherals"
-HOMEPAGE="https://pwr.github.com/Solaar/"
-SRC_URI="https://github.com/pwr/Solaar/archive/${PV}.tar.gz -> ${P}.tar.gz"
+HOMEPAGE="https://pwr-solaar.github.io/Solaar/"
+SRC_URI="https://github.com/pwr-Solaar/Solaar/archive/${PV}.tar.gz -> ${P}.tar.gz"
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="amd64 ~arm x86"
+KEYWORDS="~amd64 ~arm ~x86"
 IUSE="doc"
 
 RDEPEND=">=dev-python/pyudev-0.13[${PYTHON_USEDEP}]
@@ -51,8 +51,5 @@
 		elog "Users must be in the plugdev group to use this application."
 	fi
 
-	gnome2_icon_cache_update
+	xdg_pkg_postinst
 }
-
-pkg_preinst() { gnome2_icon_savelist; }
-pkg_postrm() { gnome2_icon_cache_update; }

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @cjmayo
Areas affected: ebuilds
Packages affected: app-misc/solaar

app-misc/solaar: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 691208


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 11, 2019
Copy link
Contributor

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Katana-Steel
Copy link

tried it on my local repo, LGTM too.

Picked up the lightspeed connctor right away..

}

pkg_postinst() {
enewgroup plugdev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is this. It should be done via the new GLEP-81 way. Also it allows you to removed the replacing_versions part below.

I'm a bit amazed and confused no one has pushed acct-group/plugdev yet...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @juippis, completely forgot about GLEP-81

@cjmayo
Copy link
Contributor Author

cjmayo commented Aug 20, 2019

GLEP 81 does say:
"The old method may still be used for existing users/groups, in existing packages."
https://www.gentoo.org/glep/glep-0081.html#id5

I haven't got time to propose acct-group/plugdev myself, but if it gets added I'm happy to update this PR.

@juippis
Copy link
Member

juippis commented Aug 21, 2019

"The old method may still be used for existing users/groups, in existing packages."
https://www.gentoo.org/glep/glep-0081.html#id5

existing packages. Meaning, old packages won't need to be updated (it would require a revbump for each one).
But new packages should follow GLEP-81.

@cjmayo
Copy link
Contributor Author

cjmayo commented Aug 21, 2019

To me this is a version bump of an existing package, not a new package, using an existing group that has already been created by many ebuilds.
Not to say that using the new system wouldn't be a good thing.

Bug: https://bugs.gentoo.org/691208
Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Chris Mayo <aklhfex@gmail.com>
@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 13, 2019

acct-group/plugdev now available, updated to use it and remove REPLACING_VERSIONS (indeed whole pkg_postinst) as suggested.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-13 19:18 UTC
Newest commit scanned: 86180f7
Status: ✅ good

No issues found

@cjmayo cjmayo deleted the solaar-1.0.1 branch September 17, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
6 participants