New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-misc/solaar: Version bump to 1.0.1, Python 3.7 and EAPI 7 #12679
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @cjmayo app-misc/solaar: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 691208 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tried it on my local repo, LGTM too. Picked up the lightspeed connctor right away.. |
app-misc/solaar/solaar-1.0.1.ebuild
Outdated
} | ||
|
||
pkg_postinst() { | ||
enewgroup plugdev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is this. It should be done via the new GLEP-81 way. Also it allows you to removed the replacing_versions part below.
I'm a bit amazed and confused no one has pushed acct-group/plugdev yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @juippis, completely forgot about GLEP-81
GLEP 81 does say: I haven't got time to propose acct-group/plugdev myself, but if it gets added I'm happy to update this PR. |
existing packages. Meaning, old packages won't need to be updated (it would require a revbump for each one). |
To me this is a version bump of an existing package, not a new package, using an existing group that has already been created by many ebuilds. |
Bug: https://bugs.gentoo.org/691208 Package-Manager: Portage-2.3.69, Repoman-2.3.16 Signed-off-by: Chris Mayo <aklhfex@gmail.com>
0f00c57
to
86180f7
Compare
acct-group/plugdev now available, updated to use it and remove REPLACING_VERSIONS (indeed whole pkg_postinst) as suggested. |
Pull request CI reportReport generated at: 2019-09-13 19:18 UTC No issues found |
Bug: https://bugs.gentoo.org/691208
Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Chris Mayo aklhfex@gmail.com
Update web addresses and swap gnome2-utils for xdg.