Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www-misc/monitorix bump to version 3.8.1 #1269

Closed
wants to merge 4 commits into from
Closed

www-misc/monitorix bump to version 3.8.1 #1269

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2016

Version bump requested in Bug#539480:

Pedro Arizmendi added 4 commits April 15, 2016 22:22
www-misc/monitorix: Renamed init file
52c99cd 
Renamed the init file to just the package name,
since the same version its compatible with higher
package versions.

Package-Manager: portage-2.2.26
www-misc/monitorix: Added graph USE variable
57c1b48 
Added graph USE variable to net-analyzer/rrdtool,
since its needed to plot the png graphs.

Package-Manager: portage-2.2.26
www-misc/monitorix: Version bump to 3.6.0
06b1be9 
Version bump to 3.6.0.
Updated SRC_URI to use GitHub repo.

Package-Manager: portage-2.2.26
www-misc/monitorix: version bump to 3.8.1
80ecf8b 
This was requested in bug 539480.

Package-Manager: portage-2.2.26
@ghost ghost mentioned this pull request Apr 15, 2016
Closed
@monsieurp
Copy link
Member

@gentoo/proxy-maint

@monsieurp monsieurp added bugfix assigned PR successfully assigned to the package maintainer(s). labels Apr 15, 2016
@sbraz
Copy link
Member

sbraz commented Apr 15, 2016

Nice :)
I have a few questions/remarks:

  • why do you add version 3.6.0 in addition to 3.8.1?
  • you should use EAPI=6 if possible
  • you can force-push to avoid closing and re-opening pull requests

@idella
Copy link

idella commented Apr 16, 2016 •
edited

To get this in progress I shall commit this as is.
Adding two versions is not the norm. The norm is to add only the latest. The vn. 3.6.0 can be removed any time.
The version that could be removed is the oldest and only current version. However it is standard to first add the new version and allow time for testing by the user community in case the new additions have flaws before removing a version with no open bugs.
Yes it is desired to set to the most recent / current EAPI. You can do this any time now. EAPI changes by their nature cause possible changes to be needed within the ebuild.
Yes it is tedious and unnecessary to close pull requests when the patch(es) can be updated by force push
You have missed editing the file metadata.xml. I have done this separately

gentoo-bot pushed a commit that referenced this pull request Apr 16, 2016
www-misc/monitorix: Added graph USE variable
6c9a0c8 
Added graph USE variable to net-analyzer/rrdtool,
since its needed to plot the png graphs.

Package-Manager: portage-2.2.26
Closes: #1269

Signed-off-by: Ian Delaney <idella4@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Apr 16, 2016
www-misc/monitorix: Version bump to 3.6.0
7292869 
Version bump to 3.6.0.
Updated SRC_URI to use GitHub repo.

Package-Manager: portage-2.2.26
Closes: #1269

Signed-off-by: Ian Delaney <idella4@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Apr 16, 2016
www-misc/monitorix: version bump to 3.8.1
c5ba7ee 
This was requested in bug 539480.

Package-Manager: portage-2.2.26
Closes: #1269

Signed-off-by: Ian Delaney <idella4@gentoo.org>
@ghost ghost deleted the monitorix branch April 16, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
Milestone
No milestone
3 participants
@monsieurp @sbraz @idella