dev-libs/granite 5.2.4

[lovesegfault]

Closes: https://bugs.gentoo.org/692046
Package-Manager: Portage-2.3.71, Repoman-2.3.17
RepoMan-Options: --force
Signed-off-by: Bernardo Meurer bernardo@standard.ai

[juippis]

Now if you could squash these commits into one I'd say it'd be ready.

EDIT:

Program valadoc found: NO

doc/meson.build:1:0: ERROR: Program(s) ['valadoc'] not found or not executable

A full log can be found at /var/tmp/portage/dev-libs/granite-5.2.4/work/granite-5.2.4-build/meson-logs/meson-log.txt
 * ERROR: dev-libs/granite-5.2.4::testworld failed (configure phase):
 *   (no error message)

with doc USE flag on...

[lovesegfault]

@juippis squashed and fixed the doc issue :)

[juippis]

Did you test the doc issue? It's still not working for me. I'm not saying its your fault, but this seems weird and is not working out-of-the-box for me.

#  equery f vala | grep doc
/usr/bin/valadoc-0.44
/usr/include/valadoc-0.44
/usr/include/valadoc-0.44/valadoc.h
/usr/lib64/libvaladoc-0.44.so
/usr/lib64/libvaladoc-0.44.so.0
/usr/lib64/libvaladoc-0.44.so.0.0.0
/usr/lib64/pkgconfig/valadoc-0.44.pc

etc

[lovesegfault]

@juippis Hmm, I had just assumed enabling valadoc would work, but testing it now it seems to still be broken. D'oh.

Not sure how to fix this

[lovesegfault]

Going to remove the doc USE flag for now I guess, bummer!

[juippis]

It should be solvable. Try using VALA_USE_DEPEND="valadoc", and if that doesn't work a simple sed will do it.

[juippis]

https://github.com/elementary/granite/blob/master/doc/meson.build#L1
this is the problem. For now, I'd like you to either sed this line if doc USE is enabled, pointing to valadoc-$(vala_best_api_version) or make some sort of alias valadoc = (the previous command) in the ebuild.
Sorry I know the current version is broken, but this is literally one sed line away from being good and working.

[lovesegfault]

@juippis Alright! Fixed!

NB: The build still doesn't work. It errors claiming that some images in doc/images/ aren't there, when in fact I see they are there. Not sure what that's about.

[juippis]

Yeah, meson.eclass moves the files around a bit while building. Try putting this inside "if use doc; then" block

mkdir ${WORKDIR}/doc || die
cp -r doc/* ${WORKDIR}/doc/ || die

EDIT: that, mv, sedding the build files... whatever works the best for you.

[lovesegfault]

@juippis All fixed!

[juippis]

Good and bad news :)
Good: It compiled! :)
Bad: I can't find the generated docs from my system :(

You may have to manually install them with doins, or add the source directory to HTML_DOCS before calling einstalldocs.

[lovesegfault]

@juippis This ebuild is making me cry :P

[juippis]

It'll make you feel so good when it works perfectly ;)
I know this has been tedious, but we know the problem and don't want to push broken ebuilds. It'd also be faster for everyone if you checked everything beforehand so I wouldn't have to notify what is working and what is not :P
PS: It's so close now. One line away.

[lovesegfault]

@juippis I'm still working on my "ebuild checklist". Now I have "verify docs are in the right place" on it 😄

[lovesegfault]

I went to inspect this today, and I get a sandbox violation, log attached. I don't know what to do about this, first time I encounter it.

sandbox-584219.log

[juippis]

Did you figure it out? I don't see any changes between your previous commit and the latest?

If it works now, good, let me know and I'll test it. If not, here's what I was after:

use doc && local HTML_DOCS=( "${WORKDIR}"/doc/. )

where you specify path where valadoc creates those docs, this needs to be defined before calling einstalldocs (or default meson-src_install phase).

[lovesegfault]

@juippis I didn't change anything, one morning it started giving sandbox violations when the doc useflag was enabled. I tested yesterday and still got them, no idea why

[juippis]

Sigh. Builds fine for me... but these images arent even that informational. Lets just disable USE="doc" and its functions from this one... :P
Meh. At least we tried!

[lovesegfault]

Alright, I removed the doc USE, but left the code commented with a FIXME. I'll continue to pursue this issue upstream :)

[juippis]

Im not sure its an upstream issue either...

[lovesegfault]

Done @juippis!

I think it's some issue with Valadoc, but I'll leave this alone for now in to get this thing merged as it's a major, needed, bump.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2019-08-29 05:40 UTC
Newest commit scanned: af47b96
Status: ✅ good

No issues found

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @lovesegfault
Areas affected: ebuilds
Packages affected: dev-libs/granite

dev-libs/granite: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 691624

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[juippis]

Thanks for your patience, works good now :)

[lovesegfault]

Thank you for taking the time and helping me @juippis !