Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-leechcraft/liblaretz: bump version #12846

Closed
wants to merge 1 commit into from
Closed

app-leechcraft/liblaretz: bump version #12846

wants to merge 1 commit into from

Conversation

0xd34df00d
Copy link
Contributor

Bug: https://bugs.gentoo.org/628516
Signed-off-by: Georg Rudoy 0xd34df00d@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @0xd34df00d
Areas affected: ebuilds
Packages affected: app-leechcraft/liblaretz

app-leechcraft/liblaretz: @0xd34df00d, @gentoo/proxy-maint

Linked bugs

Bugs linked: 628516

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 2, 2019
juippis
juippis suggested changes Sep 2, 2019
View reviewed changes
app-leechcraft/liblaretz/liblaretz-0.1.2.ebuild Outdated
@@ -0,0 +1,21 @@
# Copyright 1999-2017 Gentoo Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use repoman to commit to fix this copyright header automatically. This is the old form.

app-leechcraft/liblaretz/liblaretz-0.1.2.ebuild Outdated
# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

EAPI=6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 7, should work.

app-leechcraft/liblaretz/liblaretz-0.1.2.ebuild Outdated

LICENSE="Boost-1.0"
SLOT="0"
KEYWORDS="amd64 x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't commit straight to stable, KEYWORDS need to be reset.

app-leechcraft/liblaretz/liblaretz-0.1.2.ebuild Outdated
KEYWORDS="amd64 x86"
IUSE=""

DEPEND="dev-libs/boost"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify whether this gets linked, ie, is subslot binding necessary here? :=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for catching this! Indeed it does!

@0xd34df00d
app-leechcraft/liblaretz: bump version
9cef7f1 
Bug: https://bugs.gentoo.org/628516
Signed-off-by: Georg Rudoy <0xd34df00d@gmail.com>
Package-Manager: Portage-2.3.73, Repoman-2.3.17
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-02 23:40 UTC
Newest commit scanned: 9cef7f1
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/1f3e2b4/output.html#media-tv/kodi

@gentoo-bot gentoo-bot closed this in b38a490 Sep 3, 2019
@0xd34df00d 0xd34df00d deleted the bump_laretz branch September 3, 2019 17:34
thebitpit pushed a commit to thebitpit/gentoo that referenced this pull request Sep 13, 2019
@0xd34df00d
app-leechcraft/liblaretz: bump version
91f96c5 
Bug: https://bugs.gentoo.org/628516
Signed-off-by: Georg Rudoy <0xd34df00d@gmail.com>
Package-Manager: Portage-2.3.73, Repoman-2.3.17
Closes: gentoo#12846
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
thebitpit pushed a commit to thebitpit/gentoo that referenced this pull request Sep 13, 2019
@0xd34df00d
app-leechcraft/liblaretz: bump version
256c03b 
Bug: https://bugs.gentoo.org/628516
Signed-off-by: Georg Rudoy <0xd34df00d@gmail.com>
Package-Manager: Portage-2.3.73, Repoman-2.3.17
Closes: gentoo#12846
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
thebitpit pushed a commit to thebitpit/gentoo that referenced this pull request Sep 14, 2019
@0xd34df00d
app-leechcraft/liblaretz: bump version
c3cb46e 
Bug: https://bugs.gentoo.org/628516
Signed-off-by: Georg Rudoy <0xd34df00d@gmail.com>
Package-Manager: Portage-2.3.73, Repoman-2.3.17
Closes: gentoo#12846
Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@0xd34df00d @gentoo-bot @gentoo-repo-qa-bot @juippis