net-im/telegram-desktop-bin: version bump to v1.8.4 and cleanup

[henning-schild]

No description provided.

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @henning-schild
Areas affected: ebuilds
Packages affected: net-im/telegram-desktop-bin

net-im/telegram-desktop-bin: @henning-schild, @NP-Hardass, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[henning-schild]

I actually think the binary should be moved to /opt for clean packaging of a -bin ebuild. Let me know what you think about that. If you agree i would make this move in this PR. And that might require a bug, not sure.

[henning-schild]

renaming to WIP, upstream came with a new bugfix release, comments on opt still welcome

[juippis]

/opt is usually used when programs don't respect the unix/linux filesystem hierarchy and "require" the directory structure to be as it is in order for the program to work. In my eyes, it doesn't seem to be the case with this one. This just installs a binary, a .desktop launcher and some icons. Everything seems to be in place. I don't really mind either way where the bin lies, as long as it doesn't break stuff.
However I don't agree with the way you're making the change. First bumping version, then a separate commit with weird replicate of a wrapper.
Whatever you decide, just do it in a single version bump and maybe add some REPLACING_VERSIONS info message that the path has been changed.

EDIT: Well about the replicate wrapper, seems like there are versions still left in the tree so you need two of them for now anyway.

[henning-schild]

The weird structure was just so that someone could merge the first two without merging the move to opt. I just dropped that now and we are good to go.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2019-09-07 09:37 UTC
Newest commit scanned: 1d11c99
Status: ✅ good

No issues found