games-fps/freedoom-data: Set DOOMWADPATH in freedoom launch script #12871
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @vilhelmgray games-fps/freedm-data: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
|
To make this work on prefix, you should use |
vilhelmgray
force-pushed
the
doomwadpath_freedoom-data
branch
from
15521b9
to
191db6e
Compare
The patch is pretty simple so I opted instead to update it to use |
|
Right but this patch has been accepted upstream and they obviously cannot add |
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
vilhelmgray
force-pushed
the
doomwadpath_freedoom-data
branch
from
191db6e
to
2740c78
Compare
I see what you mean. I've updated it now to use hprefixify instead as you suggest. |
Pull request CI reportReport generated at: 2019-09-07 16:59 UTC Issues already there before the PR (double-check them): |
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Closes: gentoo#12871 Signed-off-by: James Le Cuirot <chewi@gentoo.org>
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Closes: gentoo#12871 Signed-off-by: James Le Cuirot <chewi@gentoo.org>
Package-Manager: Portage-2.3.73, Repoman-2.3.17 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Closes: gentoo#12871 Signed-off-by: James Le Cuirot <chewi@gentoo.org>
Engines such as Odamex may not have a default search path and simply
search for freedoom1.wad relative to the current directory. This can
cause an unexpected WAD file not found error when executing the freedoom
script.
This issue is mitigated by setting a default DOOMWADPATH environment
variable with sensible search paths, if it is not already set. All
engines listed in the PORTS variable support the DOOMWADPATH environment
variable, which makes it a simple and convenient way of helping prevent
this error.