Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-gfx/qimgv: change exif flag to exiv2 flag #12891

Closed
wants to merge 1 commit into from
Closed

media-gfx/qimgv: change exif flag to exiv2 flag #12891

wants to merge 1 commit into from

Conversation

kamiyaa
Copy link
Contributor

@kamiyaa kamiyaa commented Sep 9, 2019

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @kamiyaa
Areas affected: ebuilds
Packages affected: media-gfx/qimgv

media-gfx/qimgv: @kamiyaa, @gentoo/proxy-maint

Linked bugs

Bugs linked: 693920

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 9, 2019
a17r
a17r suggested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@a17r a17r left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming the flag is not at all necessary, please stick with the global exif - it does not describe the library, but the function.

the actual fix here is only a dependency fix; this will need a revbump. please change your commit message accordingly as well.

media-gfx/exiv2 has a subslot defined, please check if you need to add a slot operator.

@kamiyaa
media-gfx/qimgv: fix exif dependency
41c5555 
Closes: https://bugs.gentoo.org/693920
Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Jiayi Zhao <jeff.no.zhao@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-13 14:56 UTC
Newest commit scanned: 41c5555
Status: ✅ good

No issues found

@kamiyaa kamiyaa closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@kamiyaa @gentoo-bot @gentoo-repo-qa-bot @a17r