Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/med: switch to cmake based build #12930

Closed
wants to merge 1 commit into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Sep 15, 2019

The patch moves back to the cmake based build used in sci-libs/libmed.
The issues with sci-libs/gmsh not building with cmake built med have
been resolved. See https://bugs.gentoo.org/693146 comments 19-22

Closes: https://bugs.gentoo.org/694468
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Bernd Waibel waebbl@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: sci-libs/med

sci-libs/med: @tamiko, @waebbl, @gentoo/sci, @gentoo/proxy-maint

Linked bugs

Bugs linked: 694468


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 15, 2019
@waebbl waebbl force-pushed the move-med-to-cmake branch 2 times, most recently from 0e0d4b1 to 7a21bff Compare September 21, 2019 12:38
@tamiko
Copy link
Member

tamiko commented Sep 22, 2019

What is the current state of this pull request?

@waebbl
Copy link
Contributor Author

waebbl commented Sep 22, 2019

From my side, I've addressed the issue from my second comment above, for installing python-3.7 files into wrong directory with the latest commit.

@juippis
Copy link
Member

juippis commented Sep 23, 2019

@tamiko you're one of the maintainers, if you find it sufficient, you can merge too.

Tests still fail for me, this is the error:

Command: "/usr/bin/env" "PYTHONPATH=/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python:/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med" "/tmp/portage/sci-libs/med-4.0.0-r2/temp/python3.6/bin/python" "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python/test3.py"
Directory: /tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python
"test3_Python" start time: Sep 23 13:11 -00
Output:
----------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python/test3.py", line 7, in <module>
    from med.medfile import *
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med/__init__.py", line 67, in <module>
    from .medenum import *
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med/medenum.py", line 13, in <module>
    from . import _medenum
ImportError: cannot import name '_medenum'
<end of output>
Test time =   0.04 sec
----------------------------------------------------------
Test Failed.
"test3_Python" end time: Sep 23 13:11 -00
"test3_Python" time elapsed: 00:00:00

Getting bunch of these.

@juippis
Copy link
Member

juippis commented Sep 23, 2019

@tamiko you're one of the maintainers, if you find it sufficient, you can merge too.

Tests still fail for me, this is the error:

Command: "/usr/bin/env" "PYTHONPATH=/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python:/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med" "/tmp/portage/sci-libs/med-4.0.0-r2/temp/python3.6/bin/python" "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python/test3.py"
Directory: /tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python
"test3_Python" start time: Sep 23 13:11 -00
Output:
----------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/tests/python/test3.py", line 7, in <module>
    from med.medfile import *
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med/__init__.py", line 67, in <module>
    from .medenum import *
  File "/tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0_build/python/med/medenum.py", line 13, in <module>
    from . import _medenum
ImportError: cannot import name '_medenum'
<end of output>
Test time =   0.04 sec
----------------------------------------------------------
Test Failed.
"test3_Python" end time: Sep 23 13:11 -00
"test3_Python" time elapsed: 00:00:00

Getting bunch of these.

With USE="-python it doesnt even go past src_prepare,

>>> Source unpacked in /tmp/portage/sci-libs/med-4.0.0-r2/work
>>> Preparing source in /tmp/portage/sci-libs/med-4.0.0-r2/work/med-4.0.0 ...
 * ERROR: sci-libs/med-4.0.0-r2::testworld failed (prepare phase):
 *   python_export called without a python implementation and EPYTHON is unset
 *
 * Call stack:
 *     ebuild.sh, line  125:  Called src_prepare
 *   environment, line 3193:  Called python_get_sitedir
 *   environment, line 2804:  Called python_export 'PYTHON_SITEDIR'
 *   environment, line 2368:  Called die

The patch moves back to the cmake based build used in sci-libs/libmed.
The issues with sci-libs/gmsh not building with cmake built med have
been resolved. See https://bugs.gentoo.org/693146 comments 19-22

Closes: https://bugs.gentoo.org/694468
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Bernd Waibel <waebbl@gmail.com>
@waebbl
Copy link
Contributor Author

waebbl commented Sep 30, 2019

I fixed the src_prepare issue. The python test failure looks like it's happening because the PYTHONPATH doesn't work as expected. If there's already a version of the package installed, the tests succeed, that's why the error didn't pop up on my machine. As of yet, I wasn't able to fix this properly. The current solution is kinda a hack, as it disables tests if USE=python is effective.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-09-30 14:38 UTC
Newest commit scanned: 00fa5f5
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/3a6fcda/output.html#games-action/crimsonland
https://qa-reports.gentoo.org/output/gentoo-ci/3a6fcda/output.html#games-roguelike/neon-chrome

@juippis
Copy link
Member

juippis commented Oct 13, 2019

Sorry for ignoring this, I once hit a similar error and I had to export PYTHONPATH (or something) to include the BUILD_DIR. I wanted to help you solve it but I realize I dont have time to test this, so lets just get this forward.

Thanks!

@waebbl waebbl deleted the move-med-to-cmake branch July 30, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants