dev-python/statsmodels: version bump 0.10.1 #12987

TheChymera · 2019-09-21T15:26:28Z

Package-Manager: Portage-2.3.75, Repoman-2.3.17
Signed-off-by: Horea Christian chr@chymera.eu

gentoo-bot · 2019-09-21T15:28:13Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @TheChymera
Areas affected: ebuilds
Packages affected: dev-python/statsmodels

dev-python/statsmodels: @gentoo/python, @gentoo/sci-mathematics, @TheChymera, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

juippis · 2019-09-22T07:05:17Z

dev-python/statsmodels/statsmodels-0.10.1.ebuild

+
+python_test() {
+	cd "${BUILD_DIR}" || die
+	python -c 'import statsmodels; statsmodels.test()' || die


Shouldn't you use ${EPYTHON}} here?

juippis · 2019-09-22T07:05:37Z

dev-python/statsmodels/statsmodels-0.10.1.ebuild

+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+PYTHON_COMPAT=( python2_7 python3_{5,6,7} )


We usually have one empty line below EAPI.

juippis · 2019-09-22T07:06:35Z

dev-python/statsmodels/statsmodels-0.10.1.ebuild

+
+python_install_all() {
+	find . -name \*LICENSE.txt -delete || die
+	use doc && HTML_DOCS=( docs/build/html/. )


It doesn't matter much, but local HTML_DOCS please (to follow PMS).

juippis · 2019-09-22T07:08:38Z

dev-python/statsmodels/statsmodels-0.10.1.ebuild

+	test? (
+		dev-python/pytest[${PYTHON_USEDEP}]
+		dev-python/nose[${PYTHON_USEDEP}]
+		)


Mis-indent.

juippis · 2019-09-22T07:59:39Z

I didnt have time to test this thorougly, but please check if sphinx modules are imported during build or if it just gets executed. the python2.7 dep for sphinx makes it impossible/annoying to solve. (Ie, remove PYTHON_USEDEP if it just gets executed)

juippis · 2019-09-22T08:01:45Z

Also,

 * Messages for package dev-python/statsmodels-0.10.1:

 *   dev-python/matplotlib for Plotting functionality
 * The ebuild is installing to one or more unexpected paths:
 * 
 *   /usr/LICENSE.txt
 *   /usr/setup.cfg

>: file /usr/setup.cfg 
/usr/setup.cfg: ASCII text

TheChymera · 2019-09-25T13:23:42Z

I didnt have time to test this thorougly, but please check if sphinx modules are imported during build or if it just gets executed. the python2.7 dep for sphinx makes it impossible/annoying to solve. (Ie, remove PYTHON_USEDEP if it just gets executed)

how can I check this?

TheChymera · 2019-09-25T13:26:20Z

As for those files, this is really strange, since they are also installed in the proper places.... should I just rm them at the beginning of python_install_all()?

chymera@darkhost ~ $ equery f statsmodels | ag LICENSE
/usr/LICENSE.txt
/usr/lib64/python2.7/site-packages/statsmodels/LICENSE.txt
/usr/lib64/python2.7/site-packages/statsmodels/stats/libqsturng/LICENSE.txt
/usr/lib64/python3.6/site-packages/statsmodels/LICENSE.txt
/usr/lib64/python3.6/site-packages/statsmodels/stats/libqsturng/LICENSE.txt
chymera@darkhost ~ $ equery f statsmodels | ag setup
/usr/lib64/python2.7/site-packages/statsmodels/setup.cfg
/usr/lib64/python3.6/site-packages/statsmodels/setup.cfg
/usr/setup.cfg

Package-Manager: Portage-2.3.75, Repoman-2.3.17 Signed-off-by: Horea Christian <chr@chymera.eu>

juippis · 2019-09-25T13:47:43Z

how can I check this?

https://github.com/statsmodels/statsmodels/blob/master/docs/Makefile
It's just executed. Basically you want to see if they use sphinx-build command to generate docs, or if the source files have import sphinx or similar.

As for the 2nd, Gentoo doesnt install LICENSEs there. Is the correct license included in portage's licenses/ folder? You can also remove them in src_install.

gentoo-repo-qa-bot · 2019-09-25T13:55:36Z

Pull request CI report

Report generated at: 2019-09-25 13:55 UTC
Newest commit scanned: 61af420
Status: ✅ good

No issues found

TheChymera · 2019-09-25T22:29:06Z

@juippis yes, ofc, it's the BSD license, should I remove all the license files entirely then?

What about setup.cfg?

juippis · 2019-09-26T05:38:56Z

I'm kinda 50-50 on the license thing. On the other hand, fast, I couldnt find a rule saying it has to be removed, but when grepping though my /usr there aren't many LICENSE.txt files installed either.

I'd say leave it for now, and leave setup.cfg if it provides documentation or functionality, but remove them from the top-level of /usr.

juippis · 2019-09-26T16:11:27Z

Are the FHS-related things fixed in your latest commit? It took me 45 minutes to compile this, I'd hate to wait that time only to notice the same errors :P

TheChymera · 2019-11-26T01:55:04Z

@juippis I'm close to giving up,

python_install_all() {
    pushd .. > /dev/null || die
        find . -wholename "*/statsmodels/LICENSE.txt" -delete || die
        find . -wholename "*/statsmodels/setup.cfg" -delete || die
        find . -wholename "*/${P}/LICENSE.txt" -delete || die
        find . -wholename "*/${P}/setup.cfg" -delete || die
    popd > /dev/null || die
    use doc && local HTML_DOCS=( docs/build/html/. )
    if use examples; then
        docompress -x /usr/share/doc/${PF}/examples
        dodoc -r examples
    fi
    distutils-r1_python_install_all
}

still won't fix it, though it deletes all occurrences except:

quiethost /var/tmp/portage/dev-python/statsmodels-0.10.1/work # find . -wholename "*LICENSE.txt*"
./statsmodels-0.10.1-python2_7/lib/statsmodels/stats/libqsturng/LICENSE.txt
./statsmodels-0.10.1/statsmodels/multivariate/factor_rotation/LICENSE.txt
./statsmodels-0.10.1/statsmodels/stats/libqsturng/LICENSE.txt
./statsmodels-0.10.1/docs/sphinxext/LICENSE.txt
./statsmodels-0.10.1-python3_6/lib/statsmodels/stats/libqsturng/LICENSE.txt
quiethost /var/tmp/portage/dev-python/statsmodels-0.10.1/work # equery f statsmodels | ag LICENSE.txt
/usr/LICENSE.txt
/usr/lib64/python2.7/site-packages/statsmodels/LICENSE.txt
/usr/lib64/python2.7/site-packages/statsmodels/stats/libqsturng/LICENSE.txt
/usr/lib64/python3.6/site-packages/statsmodels/LICENSE.txt
/usr/lib64/python3.6/site-packages/statsmodels/stats/libqsturng/LICENSE.txt

juippis · 2019-11-26T13:37:07Z

You can use cp or mv in src_install, operating in ${D} to fix these in worst case.

TheChymera · 2019-11-26T16:16:28Z

@juippis could you comment on the new version linked above?

juippis · 2019-11-26T19:13:36Z

I have already, but this was popped in my mail before the new one, so I arrived here first :)

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 21, 2019

juippis reviewed Sep 22, 2019

View reviewed changes

dev-python/statsmodels: version bump 0.10.1

61af420

Package-Manager: Portage-2.3.75, Repoman-2.3.17 Signed-off-by: Horea Christian <chr@chymera.eu>

TheChymera force-pushed the statsmodels branch from 5f36dd3 to 61af420 Compare September 25, 2019 13:27

TheChymera closed this Nov 26, 2019

TheChymera deleted the statsmodels branch November 26, 2019 10:03

TheChymera mentioned this pull request Nov 26, 2019

dev-python/statsmodels: version bump 0.10.2 #13764

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-python/statsmodels: version bump 0.10.1 #12987

dev-python/statsmodels: version bump 0.10.1 #12987

TheChymera commented Sep 21, 2019

gentoo-bot commented Sep 21, 2019

juippis Sep 22, 2019

juippis Sep 22, 2019

juippis Sep 22, 2019

juippis Sep 22, 2019

juippis commented Sep 22, 2019

juippis commented Sep 22, 2019

TheChymera commented Sep 25, 2019

TheChymera commented Sep 25, 2019

juippis commented Sep 25, 2019

gentoo-repo-qa-bot commented Sep 25, 2019

TheChymera commented Sep 25, 2019

juippis commented Sep 26, 2019

juippis commented Sep 26, 2019

TheChymera commented Nov 26, 2019

juippis commented Nov 26, 2019

TheChymera commented Nov 26, 2019

juippis commented Nov 26, 2019

dev-python/statsmodels: version bump 0.10.1 #12987

dev-python/statsmodels: version bump 0.10.1 #12987

Conversation

TheChymera commented Sep 21, 2019

gentoo-bot commented Sep 21, 2019

Copyright policy change

Pull Request assignment

Linked bugs

juippis Sep 22, 2019

Choose a reason for hiding this comment

juippis Sep 22, 2019

Choose a reason for hiding this comment

juippis Sep 22, 2019

Choose a reason for hiding this comment

juippis Sep 22, 2019

Choose a reason for hiding this comment

juippis commented Sep 22, 2019

juippis commented Sep 22, 2019

TheChymera commented Sep 25, 2019

TheChymera commented Sep 25, 2019

juippis commented Sep 25, 2019

gentoo-repo-qa-bot commented Sep 25, 2019

Pull request CI report

TheChymera commented Sep 25, 2019

juippis commented Sep 26, 2019

juippis commented Sep 26, 2019

TheChymera commented Nov 26, 2019

juippis commented Nov 26, 2019

TheChymera commented Nov 26, 2019

juippis commented Nov 26, 2019