eclass/kernel-2: respect USE=symlink #13031
Conversation
gentoo-bot
added
need assignment
bjacquin
force-pushed
the
dev/beber/kernel-2
branch
from
570ad74
to
ae834a1
Compare
Gentoo bug has been created and git commit amended to reflect this |
No such commit. |
I should have specified this commit is from the historical repo: https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=906501be57c01ac198dcdd4728098b1e30399fe2 |
bjacquin
force-pushed
the
dev/beber/kernel-2
branch
from
ae834a1
to
a62c02f
Compare
|
This change looks reasonable to me. I will push this forward with the Gentoo kernel team. Please can you rebase the PR, add a 'Signed-off-by' tag to your commit message per #13031 (comment) and re-title with '[please reassign]' so that the bot updates the relevant tags. Thanks! |
bjacquin
force-pushed
the
dev/beber/kernel-2
branch
from
a62c02f
to
e9d12c0
Compare
bjacquin
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @bjacquin @gentoo/github Linked bugsBugs linked: 695592 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2021-06-05 01:14 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
This failed for me, could be me, I'll take a better look at what I did
/usr/src # ls -1 |
kernel-2 eclass postinst_sources() creates /usr/usr/linux symlink
regardless of USE=symlink. MAKELINK variable controls the creation
of /usr/src/linux, however MAKELINK is always set to 1 only if
/usr/src/linux does not currently exist with no consideration for
USE=symlink.
This change simplify the whole /usr/usr/linux symlink creation to
instead depend on K_SYMLINK which is set if USE=symlink.
This change also refuse to remove existing /usr/usr/linux if it
currently exist while not being a symlink
Note that this is broken since 906501be57c0 ("adding symlink use flag
support")
Bug: https://bugs.gentoo.org/695592
Signed-off-by: Bertrand Jacquin <bertrand@jacquin.bzh>
|
You are correct, one if the test was not functional, sending new version. |
bjacquin
force-pushed
the
dev/beber/kernel-2
branch
from
e9d12c0
to
754bb59
Compare
Pull request CI reportReport generated at: 2021-06-07 00:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks for your work |
kernel-2 eclass postinst_sources() creates /usr/usr/linux symlink
regardless of USE=symlink. MAKELINK variable controls the creation
of /usr/src/linux, however MAKELINK is always set to 1 only if
/usr/src/linux does not currently exist with no consideration for
USE=symlink.
This change simplify the whole /usr/usr/linux symlink creation to
instead depend on K_SYMLINK which is set if USE=symlink.
This change also refuse to remove existing /usr/usr/linux if it
currently exist while not being a symlink
Note that this is broken since 626ceb860869 ("Multiple fixes.")
Bug: https://bugs.gentoo.org/695592